[cleanup] Log compile errors for AOT tests #10214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
requested review from
comaniac,
junrushao,
tqchen,
jroesch,
areusch,
yzhliu,
merrymercy and
icemelon
as code owners
driazati
force-pushed
the
aot_subproc
branch
2 times, most recently
from
6d4ae98 to
65324a8
Compare
driazati
force-pushed
the
aot_subproc
branch
4 times, most recently
from
7ad65a1 to
8325ee2
Compare
lhutton1
reviewed
Feb 25, 2022
lhutton1
reviewed
Feb 25, 2022
| proc.wait() | ||
| if proc.returncode != 0: | ||
| raise RuntimeError( | ||
| f"Subprocess failed: {cmd}\nstdout:\n{proc.stdout}\nstderr:\n{proc.stderr}" |
There was a problem hiding this comment.
The last run on CI luckily hit a flaky test, although the Runtime Error doesn't really give many details currently (other than the command that failed):
RuntimeError: Subprocess failed: make -f /workspace/tests/python/relay/aot/corstone300.mk build_dir=/tmp/tmpqlaqvgf3/test/build CFLAGS='-DTVM_RUNTIME_ALLOC_ALIGNMENT_BYTES=8 ' TVM_ROOT=/workspace/tests/python/relay/aot/../../../.. AOT_TEST_ROOT=/workspace/tests/python/relay/aot CODEGEN_ROOT=/tmp/tmpqlaqvgf3/test/codegen STANDALONE_CRT_DIR=/workspace/build/standalone_crt FVP_DIR=/opt/arm/FVP_Corstone_SSE-300/models/Linux64_GCC-6.4/ run
E stdout:
E <_io.TextIOWrapper name=7 encoding='utf-8'>
E stderr:
E None
I tried to change proc.stdout to something like proc.stdout.read() but this just returns an empty string, presumably because the lines are already read above. There will also be no stderr since this is passed to stdout in the subprocess declaration.
We could make the error visible by adding the contents of the log file to the error message, although I don't think this is very elegant. Any other ideas?
There was a problem hiding this comment.
added a side channel variable to capture the same info, seems to work locally
* removed the encode of msg that is already str Co-authored-by: lhutton1 <[email protected]>
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* [cleanup] Log compile errors for AOT tests See apache#10213 * Update tests/python/relay/aot/aot_test_utils.py * removed the encode of msg that is already str Co-authored-by: lhutton1 <[email protected]> Co-authored-by: driazati <[email protected]> Co-authored-by: Manupa Karunaratne <[email protected]> Co-authored-by: lhutton1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10213