-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CUTLASS] Profile only the largest-possible alignment by default #10036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
kazum,
liangfu,
merrymercy,
tmoreau89,
tqchen,
vinx13,
yzhliu,
zhiics and
ZihengJiang
as code owners
January 24, 2022 02:25
comaniac
reviewed
Jan 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
masahi
force-pushed
the
cutlass-largest-alignment
branch
2 times, most recently
from
January 24, 2022 19:42
19a8f8c
to
340bc5d
Compare
comaniac
approved these changes
Jan 24, 2022
masahi
force-pushed
the
cutlass-largest-alignment
branch
from
January 25, 2022 01:10
e5b8825
to
771c8b7
Compare
masahi
force-pushed
the
cutlass-largest-alignment
branch
from
January 26, 2022 00:54
771c8b7
to
6de3d64
Compare
sunggg
pushed a commit
to sunggg/tvm
that referenced
this pull request
Jan 29, 2022
…che#10036) * introduce profile_all_alignments option * add profile_all_alignment option to API * wip * fixed dynamic case * black * update gen_gemm too * minor improvement * fix * all tests work * add doc * fixed for sm = 75 case * fix typo * remove unused import * profile_all -> find_first_valid * fix
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
…che#10036) * introduce profile_all_alignments option * add profile_all_alignment option to API * wip * fixed dynamic case * black * update gen_gemm too * minor improvement * fix * all tests work * add doc * fixed for sm = 75 case * fix typo * remove unused import * profile_all -> find_first_valid * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we can use 8-elements alignment for fp16, for example, there is no need to profile smaller alignment variants since
align8
ones are always faster thanalign4
,align2
etc. This should result in 3-4x speedup in tuning time.Other changes
generate -> reject later
.sm = 75
@comaniac @Laurawly