Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C Interface API Generation split between Python and C++ #8792

Closed
Mousius opened this issue Aug 19, 2021 · 0 comments · Fixed by #9106
Closed

C Interface API Generation split between Python and C++ #8792

Mousius opened this issue Aug 19, 2021 · 0 comments · Fixed by #9106

Comments

@Mousius
Copy link
Member

Mousius commented Aug 19, 2021

Currently the Interface API header is generated in Python:
https://github.com/apache/tvm/blob/main/python/tvm/micro/interface_api.py

And the source it references is generated in C++:
https://github.com/apache/tvm/blob/main/src/target/source/source_module.cc#L237

This leads to re-implementing logic, such as name sanitising, in the two different languages. These should be consolidated to generating both header and source in C++. My opening suggestion for a file name is src/target/source/interface_c.cc 😸

See discussion here: #8720

Mousius added a commit to Mousius/tvm that referenced this issue Sep 24, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python.

Follow up PRs will clean up any remaining name transformation inconsistencies.

Fixes apache#8792
Mousius added a commit to Mousius/tvm that referenced this issue Sep 24, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python.

Follow up PRs will clean up any remaining name transformation inconsistencies.

Fixes apache#8792
Mousius added a commit to Mousius/tvm that referenced this issue Sep 30, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation.

Follow up PRs will clean up any remaining name transformation inconsistencies.

Fixes apache#8792
Mousius added a commit to Mousius/tvm that referenced this issue Oct 1, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation.

Follow up PRs will clean up any remaining name transformation inconsistencies.

Fixes apache#8792
Mousius added a commit to Mousius/tvm that referenced this issue Oct 7, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation.

Follow up PRs will clean up any remaining name transformation inconsistencies.

Fixes apache#8792
Mousius added a commit to Mousius/tvm that referenced this issue Oct 7, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation.

Follow up PRs will clean up any remaining name transformation inconsistencies.

Fixes apache#8792
Mousius added a commit to Mousius/tvm that referenced this issue Oct 7, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation.

Follow up PRs will clean up any remaining name transformation inconsistencies.

Fixes apache#8792
manupak pushed a commit that referenced this issue Oct 8, 2021
Using the new name transformations added in #9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation.

Follow up PRs will clean up any remaining name transformation inconsistencies.

Fixes #8792
masahi pushed a commit to Laurawly/tvm-1 that referenced this issue Oct 14, 2021
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation.

Follow up PRs will clean up any remaining name transformation inconsistencies.

Fixes apache#8792
ylc pushed a commit to ylc/tvm that referenced this issue Jan 7, 2022
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation.

Follow up PRs will clean up any remaining name transformation inconsistencies.

Fixes apache#8792
ylc pushed a commit to ylc/tvm that referenced this issue Jan 13, 2022
Using the new name transformations added in apache#9088, the C interface API is now generated in C++ rather than in Python. This is intended to be a no-op for the actual users of this change and thus I've undone some of my overzealous sanitizing to match that expectation.

Follow up PRs will clean up any remaining name transformation inconsistencies.

Fixes apache#8792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant