Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs][Bug] Image missing for UMA tutorial #13304

Closed
StrongerXi opened this issue Nov 6, 2022 · 2 comments
Closed

[Docs][Bug] Image missing for UMA tutorial #13304

StrongerXi opened this issue Nov 6, 2022 · 2 comments
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: doc

Comments

@StrongerXi
Copy link
Contributor

The image in this section of the UMA tutorial is missing.

Root cause seems to be that it's missing in the corresponding resource url.
@StrongerXi StrongerXi added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: doc labels Nov 6, 2022
@qzylalala
Copy link
Contributor

URL: https://raw.githubusercontent.com/apache/tvm-site/main/images/tutorial/uma_vanilla_block_diagram.png
But still not found

@cbalint13 cbalint13 mentioned this issue Dec 15, 2022
Merged
lhutton1 pushed a commit that referenced this issue Dec 16, 2022
@cbalint13
[BugFix][UMA] Protect target registration (#13624)
0eabbac 
This PR address fixes for UMA target registration.
* Fix the doc issue #13304 
* Continues stalled PR #12731 

Changes:
* Incorporates all proposed fixes from mentioned [PR #12731](#12731)
* Address test case concerns and discussions from [PR #12731](#12731)
* **NEW:** Already exiting target cannot be created, explicit error on this.
* **NEW:** Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.
@lhutton1
Copy link
Contributor

Closing as this should be fixed by #13624, the docs may take a bit of time to bring in the change. Feel free to reopen if the problem persists.

leandron pushed a commit to leandron/tvm that referenced this issue Jan 19, 2023
@cbalint13 @leandron
[BugFix][UMA] Protect target registration (apache#13624)
da30a4a 
This PR address fixes for UMA target registration.
* Fix the doc issue apache#13304
* Continues stalled PR apache#12731

Changes:
* Incorporates all proposed fixes from mentioned [PR apache#12731](apache#12731)
* Address test case concerns and discussions from [PR apache#12731](apache#12731)
* **NEW:** Already exiting target cannot be created, explicit error on this.
* **NEW:** Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.

(cherry picked from commit 0eabbac)
leandron pushed a commit to leandron/tvm that referenced this issue Feb 2, 2023
@cbalint13 @leandron
[BugFix][UMA] Protect target registration (apache#13624)
2f999d6 
This PR address fixes for UMA target registration.
* Fix the doc issue apache#13304 
* Continues stalled PR apache#12731 

Changes:
* Incorporates all proposed fixes from mentioned [PR apache#12731](apache#12731)
* Address test case concerns and discussions from [PR apache#12731](apache#12731)
* **NEW:** Already exiting target cannot be created, explicit error on this.
* **NEW:** Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.
tqchen pushed a commit to tqchen/tvm that referenced this issue Feb 20, 2023
@cbalint13 @tqchen
[BugFix][UMA] Protect target registration (apache#13624)
e0ebf28 
This PR address fixes for UMA target registration.
* Fix the doc issue apache#13304 
* Continues stalled PR apache#12731 

Changes:
* Incorporates all proposed fixes from mentioned [PR apache#12731](apache#12731)
* Address test case concerns and discussions from [PR apache#12731](apache#12731)
* **NEW:** Already exiting target cannot be created, explicit error on this.
* **NEW:** Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.
@tqchen tqchen mentioned this issue Feb 20, 2023
Merged
tqchen pushed a commit to tqchen/tvm that referenced this issue Feb 20, 2023
@cbalint13 @tqchen
[BugFix][UMA] Protect target registration (apache#13624)
50b33ac 
This PR address fixes for UMA target registration.
* Fix the doc issue apache#13304
* Continues stalled PR apache#12731

Changes:
* Incorporates all proposed fixes from mentioned [PR apache#12731](apache#12731)
* Address test case concerns and discussions from [PR apache#12731](apache#12731)
* **NEW:** Already exiting target cannot be created, explicit error on this.
* **NEW:** Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.

Signed-off-by: tqchen <[email protected]>
tqchen pushed a commit to tqchen/tvm that referenced this issue Feb 20, 2023
@cbalint13 @tqchen
[BugFix][UMA] Protect target registration (apache#13624)
8141744 
This PR address fixes for UMA target registration.
* Fix the doc issue apache#13304
* Continues stalled PR apache#12731

Changes:
* Incorporates all proposed fixes from mentioned [PR apache#12731](apache#12731)
* Address test case concerns and discussions from [PR apache#12731](apache#12731)
* **NEW:** Already exiting target cannot be created, explicit error on this.
* **NEW:** Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.

Signed-off-by: tqchen <[email protected]>
tqchen added a commit to tqchen/tvm that referenced this issue Feb 20, 2023
@tqchen @cbalint13
[BugFix][UMA] Protect target registration (apache#13624)
a2c01ac 
This PR address fixes for UMA target registration.
* Fix the doc issue apache#13304
* Continues stalled PR apache#12731

Changes:
* Incorporates all proposed fixes from mentioned [PR apache#12731](apache#12731)
* Address test case concerns and discussions from [PR apache#12731](apache#12731)
* **NEW:** Already exiting target cannot be created, explicit error on this.
* **NEW:** Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.

Co-authored-by: Balint Cristian <[email protected]>
@tqchen tqchen mentioned this issue Feb 20, 2023
Merged
tqchen added a commit to tqchen/tvm that referenced this issue Feb 20, 2023
@tqchen @cbalint13
[BugFix][UMA] Protect target registration (apache#13624) (#2)
7002557 
This PR address fixes for UMA target registration.
* Fix the doc issue apache#13304
* Continues stalled PR apache#12731

Changes:
* Incorporates all proposed fixes from mentioned [PR apache#12731](apache#12731)
* Address test case concerns and discussions from [PR apache#12731](apache#12731)
* **NEW:** Already exiting target cannot be created, explicit error on this.
* **NEW:** Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.

Signed-off-by: tqchen <[email protected]>
Co-authored-by: Balint Cristian <[email protected]>
@tqchen tqchen mentioned this issue Feb 20, 2023
Merged
tqchen added a commit to tqchen/tvm that referenced this issue Feb 20, 2023
@tqchen @cbalint13
[BugFix][UMA] Protect target registration (apache#13624) (#3)
e5906e1 
This PR address fixes for UMA target registration.
* Fix the doc issue apache#13304
* Continues stalled PR apache#12731

Changes:
* Incorporates all proposed fixes from mentioned [PR apache#12731](apache#12731)
* Address test case concerns and discussions from [PR apache#12731](apache#12731)
* **NEW:** Already exiting target cannot be created, explicit error on this.
* **NEW:** Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.

Signed-off-by: tqchen <[email protected]>
Co-authored-by: Balint Cristian <[email protected]>
@tqchen tqchen mentioned this issue Feb 20, 2023
Merged
tqchen added a commit to tqchen/tvm that referenced this issue Feb 20, 2023
@tqchen @cbalint13
[BugFix][UMA] Protect target registration (apache#13624) (#4)
8c1361e 
This PR address fixes for UMA target registration.
* Fix the doc issue apache#13304
* Continues stalled PR apache#12731

Changes:
* Incorporates all proposed fixes from mentioned [PR apache#12731](apache#12731)
* Address test case concerns and discussions from [PR apache#12731](apache#12731)
* **NEW:** Already exiting target cannot be created, explicit error on this.
* **NEW:** Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.

Signed-off-by: tqchen <[email protected]>
Co-authored-by: Balint Cristian <[email protected]>
tqchen added a commit that referenced this issue Feb 20, 2023
@tqchen @cbalint13
[BugFix][UMA] Protect target registration (#13624) (#14057)
9bc6532 
[BugFix][UMA] Protect target registration (#13624) (#4)

This PR address fixes for UMA target registration.
* Fix the doc issue #13304
* Continues stalled PR #12731

Changes:
* Incorporates all proposed fixes from mentioned [PR #12731](#12731)
* Address test case concerns and discussions from [PR #12731](#12731)
* **NEW:** Already exiting target cannot be created, explicit error on this.
* **NEW:** Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.

Signed-off-by: tqchen <[email protected]>
Co-authored-by: Balint Cristian <[email protected]>
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this issue Mar 27, 2023
@cbalint13 @fzi-peccia
[BugFix][UMA] Protect target registration (apache#13624)
54358e0 
This PR address fixes for UMA target registration.
* Fix the doc issue apache#13304 
* Continues stalled PR apache#12731 

Changes:
* Incorporates all proposed fixes from mentioned [PR apache#12731](apache#12731)
* Address test case concerns and discussions from [PR apache#12731](apache#12731)
* **NEW:** Already exiting target cannot be created, explicit error on this.
* **NEW:** Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.
mikeseven pushed a commit to mikeseven/tvm that referenced this issue Sep 27, 2023
@cbalint13
[BugFix][UMA] Protect target registration (apache#13624)
6e56bb4 
This PR address fixes for UMA target registration.
* Fix the doc issue apache#13304 
* Continues stalled PR apache#12731 

Changes:
* Incorporates all proposed fixes from mentioned [PR apache#12731](apache#12731)
* Address test case concerns and discussions from [PR apache#12731](apache#12731)
* **NEW:** Already exiting target cannot be created, explicit error on this.
* **NEW:** Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: doc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@StrongerXi @lhutton1 @qzylalala