Merge branch 'relay-parser-pp' of https://github.com/jroesch/tvm into…

… relay-parser-pp

python/tvm/relay/_parser.py

@@ -4,11 +4,12 @@
 from __future__ import absolute_import
 
 import sys
-import tvm
 
 from collections import deque
 from typing import TypeVar, Deque, Tuple, Optional, Union, NamedTuple, List, Callable, Any, Dict
 
+import tvm
+
 from . import module
 from .base import Span, SourceName
 from . import expr
@@ -80,7 +81,14 @@ def lookup(scopes, name):
     return None
 
 def spanify(f):
-    """ Adds span information to the output of f. """
+    """A decorator which attaches span information
+       to the value returned by calling `f`.
+
+       Intended for use with the below AST visiting
+       methods. The idea is that after we do the work
+       of constructing the AST we attach Span information.
+    """
+
     def _wrapper(*args, **kwargs):
         # 0th arg assumed to be self. Gets source name from object.
         sn = args[0].source_name
@@ -299,6 +307,7 @@ def visitBinOp(self, ctx):
     @spanify
     def visitVar(self, ctx):
         # type: (RelayParser.VarContext) -> expr.Var
+        """Visit a single variable."""
         ident = ctx.ident().LOCAL_VAR()
 
         if ident is None:
@@ -316,13 +325,14 @@ def visitVarList(self, ctx):
     def visitAttr(self, ctx):
         # type: (RelayParser.AttrContext) -> Tuple[str, expr.Expr]
         return (ctx.CNAME().getText(), self.visit(ctx.expr()))
-    
+
     def visitAttrList(self, ctx):
         # type: (RelayParser.AttrListContext) -> Dict[str, expr.Expr]
         return dict(self.visit_list(ctx.attr()))
 
     def visitArgList(self, ctx):
-        # type: (RelayParser.ArgListContext) -> Tuple[Optional[List[expr.Var]], Optional[Dict[str, expr.Expr]]]
+        # type: (RelayParser.ArgListContext) ->
+        #   Tuple[Optional[List[expr.Var]], Optional[Dict[str, expr.Expr]]]
         var_list = self.visit(ctx.varList()) if ctx.varList() else None
         attr_list = self.visit(ctx.attrList()) if ctx.attrList() else None
 

python/tvm/relay/parser.py

@@ -3,7 +3,11 @@
 from .. import register_func
 
 def enabled():
-    """Is the parser enabled/Can we import the parser?"""
+    """Checks whether the parser is enabled, this allows users to
+       optionally support building the parser.
+
+       We use this check before importing the parser.
+    """
     try:
         # pylint: disable=unused-variable
         from tvm.relay import _parser