[Relay][Frontend][Onnx] Small bug fix for Conv1D imports. (#5995)

* Fix autopad bug in onnx importer for conv1d. * Fix output shape in test. * Undo commented out lines oops.
apache · Jul 6, 2020 · a64feed · a64feed
1 parent 67a7497
commit a64feed
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/python/tvm/relay/op/nn/nn.py b/python/tvm/relay/op/nn/nn.py
@@ -108,8 +108,7 @@ def conv1d(data,
         strides = (strides, )
     if isinstance(dilation, int):
         dilation = (dilation, )
-    if isinstance(padding, int):
-        padding = (padding, padding)
+    padding = get_pad_tuple1d(padding)
     return _make.conv1d(data, weight, strides, padding, dilation,
                         groups, channels, kernel_size, data_layout,
                         kernel_layout, out_layout, out_dtype)

diff --git a/tests/python/frontend/onnx/test_forward.py b/tests/python/frontend/onnx/test_forward.py
@@ -2180,6 +2180,15 @@ def repeat(N, D):
                     repeat(1, D),
                     repeat(1, D),
                     auto_pad="SAME_UPPER")
+        # Convolution with valid autopadding
+        verify_conv((1, 1) + repeat(5, D),
+                    (1, 1) + repeat(3, D),
+                    (1, 1) + repeat(3, D),
+                    None,
+                    repeat(3, D),
+                    repeat(1, D),
+                    repeat(1, D),
+                    auto_pad="VALID")
         # Convolution with unset padding
         verify_conv((1, 1) + repeat(5, D),
                     (1, 1) + repeat(3, D),