respond to yongwww's comments

apache · Aug 24, 2020 · 99ac920 · 99ac920
1 parent f98a29d
commit 99ac920
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/python/tvm/relay/op/_transform.py b/python/tvm/relay/op/_transform.py
@@ -140,6 +140,7 @@ def _strided_slice_shape_func_input_shape(data_shape, begin, end, strides, slice
             cbegin = int64(begin[i])
             if cbegin < 0:
                 cbegin += int64(data_shape[i])
+            assert cbegin >= 0, "begin value is too negative"
         if len(end) <= i:
             cend = int64(data_shape[i])
         elif slice_mode != 0:
@@ -155,6 +156,7 @@ def _strided_slice_shape_func_input_shape(data_shape, begin, end, strides, slice
                 cend = int64(end[i])
                 if cend < 0:
                     cend += int64(data_shape[i])
+            assert cend >= 0, "end value is too negative"
         assert cstride != 0, "Strides can't be zero."
         if cstride < 0:
             slice_range = cbegin - cend

diff --git a/python/tvm/relay/op/dyn/_transform.py b/python/tvm/relay/op/dyn/_transform.py
@@ -163,6 +163,7 @@ def _strided_slice_shape_func_input_data(data, begin, end, strides,
             cbegin = int64(begin[i])
             if cbegin < 0:
                 cbegin += int64(data.shape[i])
+            assert cbegin >= 0, "begin value is too negative"
         if end.shape[0] <= i:
             cend = int64(data.shape[i])
         elif slice_mode != 0:
@@ -178,6 +179,7 @@ def _strided_slice_shape_func_input_data(data, begin, end, strides,
                 cend = int64(end[i])
                 if cend < 0:
                     cend += int64(data.shape[i])
+                assert cend >= 0, "end value is too negative"
         assert cstride != 0, "Strides can't be zero."
         if cstride < 0:
             slice_range = cbegin - cend

diff --git a/src/relay/op/tensor/transform.cc b/src/relay/op/tensor/transform.cc
@@ -2070,9 +2070,9 @@ bool StridedSliceRel(const Array<Type>& types, int num_inputs, const Attrs& attr
       oshape[i] = tir::make_const(dshape[i].dtype(), (slice_range + step - 1) / step);
     }
   } else {
-    CHECK(param->begin) << "strided_slice recieved invalid begin";
-    CHECK(param->end) << "strided_slice recieved invalid end";
-    CHECK(param->strides) << "strided_slice recieved invalid strides";
+    CHECK(param->begin) << "strided_slice recieved invalid begin " << param->begin;
+    CHECK(param->end) << "strided_slice recieved invalid end " << param->end;
+    CHECK(param->strides) << "strided_slice recieved invalid strides " << param->strides;
   }
   reporter->Assign(types[1], TensorType(oshape, data->dtype));
   return true;