Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for ATC 8.0.1 release #7969

Merged
merged 19 commits into from
Mar 20, 2024

Conversation

rimashah25
Copy link
Contributor

This PR is not related to any issues. It includes all the changes required for a release


Which Traffic Control components are affected by this PR?

  • Traffic Ops
  • Traffic Router
  • Traffic Portal
  • Version

What is the best way to verify this PR?

N/A

If this is a bugfix, which Traffic Control versions contained the bug?

N/A

PR submission checklist

asf-ci-trafficcontrol and others added 16 commits March 20, 2024 11:57
Update chromedriver

(cherry picked from commit 8d1b4e3)
Update chromedriver

(cherry picked from commit 578f04e)
Update chromedriver

(cherry picked from commit f91c341)
Update chromedriver

(cherry picked from commit a423170)
…ache#7945)

Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9.
- [Commits](indutny/node-ip@v1.1.8...v1.1.9)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 6c6eebc)
…pache#7951)

Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.62 to 0.10.64.
- [Release notes](https://github.com/medikoo/es5-ext/releases)
- [Changelog](https://github.com/medikoo/es5-ext/blob/main/CHANGELOG.md)
- [Commits](medikoo/es5-ext@v0.10.62...v0.10.64)

---
updated-dependencies:
- dependency-name: es5-ext
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit e05e709)
Update chromedriver

(cherry picked from commit 1464dc2)
Co-authored-by: asf-ci-trafficcontrol <[email protected]>
(cherry picked from commit dc995a9)
Update chromedriver

(cherry picked from commit 26a2f6a)
@rimashah25 rimashah25 mentioned this pull request Mar 20, 2024
4 tasks
@rimashah25 rimashah25 added Traffic Ops related to Traffic Ops Traffic Router related to Traffic Router Traffic Portal v1 related to Traffic Portal version 1 process labels Mar 20, 2024
@rimashah25 rimashah25 marked this pull request as ready for review March 20, 2024 19:44
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 28.87%. Comparing base (2190789) to head (cc4e70d).

❗ Current head cc4e70d differs from pull request most recent head acaa922. Consider uploading reports for the commit acaa922 to get more accurate results

Files Patch % Lines
...ffic_ops_golang/deliveryservice/servers/servers.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              8.0.x    #7969      +/-   ##
============================================
- Coverage     31.75%   28.87%   -2.89%     
  Complexity       98       98              
============================================
  Files           717      850     +133     
  Lines         82786    90980    +8194     
  Branches        970      970              
============================================
- Hits          26289    26268      -21     
- Misses        54339    62548    +8209     
- Partials       2158     2164       +6     
Flag Coverage Δ
golib_unit 45.68% <ø> (-7.89%) ⬇️
grove_unit 4.60% <ø> (-7.42%) ⬇️
t3c_unit 4.82% <ø> (-1.07%) ⬇️
traffic_monitor_unit 20.67% <ø> (-4.80%) ⬇️
traffic_ops_integration 69.42% <ø> (ø)
traffic_ops_unit 21.06% <0.00%> (-0.58%) ⬇️
traffic_portal_v2 74.35% <ø> (-0.02%) ⬇️
traffic_router_unit 29.03% <ø> (ø)
traffic_stats_unit 10.16% <ø> (-0.63%) ⬇️
unit_tests 26.12% <0.00%> (-2.95%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zrhoffman
Copy link
Member

Everything that depends on TO seems to be failing, probably from this (from the Go Vet run:

 # github.com/apache/trafficcontrol/v8/traffic_ops/traffic_ops_golang/deliveryservice/servers
Error: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go:770:20: undefined: api.Info
# github.com/apache/trafficcontrol/v8/traffic_ops/traffic_ops_golang/deliveryservice/servers
# [github.com/apache/trafficcontrol/v8/traffic_ops/traffic_ops_golang/deliveryservice/servers]
Error: vet: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go:770:20: undefined: api.Info

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except the contract tests. Happy to approve once those pass too

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@zrhoffman zrhoffman merged commit cb8dba7 into apache:8.0.x Mar 20, 2024
45 of 46 checks passed
@rimashah25 rimashah25 deleted the atc-8.0.1-release-changes branch March 21, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1 Traffic Router related to Traffic Router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants