-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for ATC 8.0.1 release #7969
Changes for ATC 8.0.1 release #7969
Conversation
Update chromedriver (cherry picked from commit 8d1b4e3)
Update chromedriver (cherry picked from commit 578f04e)
Update chromedriver (cherry picked from commit f91c341)
Update chromedriver (cherry picked from commit a423170)
…ache#7945) Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9. - [Commits](indutny/node-ip@v1.1.8...v1.1.9) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 6c6eebc)
…pache#7951) Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.62 to 0.10.64. - [Release notes](https://github.com/medikoo/es5-ext/releases) - [Changelog](https://github.com/medikoo/es5-ext/blob/main/CHANGELOG.md) - [Commits](medikoo/es5-ext@v0.10.62...v0.10.64) --- updated-dependencies: - dependency-name: es5-ext dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit e05e709)
Update chromedriver (cherry picked from commit 1464dc2)
Co-authored-by: asf-ci-trafficcontrol <[email protected]> (cherry picked from commit dc995a9)
Update chromedriver (cherry picked from commit 26a2f6a)
11871a6
to
74e6dea
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.0.x #7969 +/- ##
============================================
- Coverage 31.75% 28.87% -2.89%
Complexity 98 98
============================================
Files 717 850 +133
Lines 82786 90980 +8194
Branches 970 970
============================================
- Hits 26289 26268 -21
- Misses 54339 62548 +8209
- Partials 2158 2164 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Everything that depends on TO seems to be failing, probably from this (from the Go Vet run: # github.com/apache/trafficcontrol/v8/traffic_ops/traffic_ops_golang/deliveryservice/servers
Error: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go:770:20: undefined: api.Info
# github.com/apache/trafficcontrol/v8/traffic_ops/traffic_ops_golang/deliveryservice/servers
# [github.com/apache/trafficcontrol/v8/traffic_ops/traffic_ops_golang/deliveryservice/servers]
Error: vet: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go:770:20: undefined: api.Info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except the contract tests. Happy to approve once those pass too
a9ff41b
to
cc4e70d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This PR is not related to any issues. It includes all the changes required for a release
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
N/A
If this is a bugfix, which Traffic Control versions contained the bug?
N/A
PR submission checklist