-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tenants rfc3339 apiv5 #7749
Tenants rfc3339 apiv5 #7749
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7749 +/- ##
=============================================
- Coverage 65.05% 31.95% -33.10%
Complexity 98 98
=============================================
Files 314 712 +398
Lines 12365 81652 +69287
Branches 907 965 +58
=============================================
+ Hits 8044 26092 +18048
- Misses 3968 53409 +49441
- Partials 353 2151 +1798
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 367 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You addressed my comments already in updates, just 1 last nit about import order )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog looks a little weird, once that's fixed I can merge :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Related: #5911
This PR changes the returned timestamp to be RFC3339 format for tenants in APIv5.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Ensure tests pass
Hit the
tenants
endpoint for v5 and verify that the timestamps returned are in RFC3339 format.If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist