Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenants rfc3339 apiv5 #7749

Merged
merged 12 commits into from
Aug 28, 2023
Merged

Conversation

kdamichie
Copy link
Contributor

@kdamichie kdamichie commented Aug 25, 2023

Related: #5911
This PR changes the returned timestamp to be RFC3339 format for tenants in APIv5.


Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Ops

What is the best way to verify this PR?

Ensure tests pass
Hit the tenants endpoint for v5 and verify that the timestamps returned are in RFC3339 format.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@zrhoffman zrhoffman added Traffic Ops related to Traffic Ops tech debt rework due to choosing easy/limited solution medium impact impacts a significant portion of a CDN, or has the potential to do so labels Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #7749 (21ec3a9) into master (75ec56f) will decrease coverage by 33.10%.
Report is 90 commits behind head on master.
The diff coverage is 60.64%.

@@              Coverage Diff              @@
##             master    #7749       +/-   ##
=============================================
- Coverage     65.05%   31.95%   -33.10%     
  Complexity       98       98               
=============================================
  Files           314      712      +398     
  Lines         12365    81652    +69287     
  Branches        907      965       +58     
=============================================
+ Hits           8044    26092    +18048     
- Misses         3968    53409    +49441     
- Partials        353     2151     +1798     
Flag Coverage Δ
golib_unit 53.68% <60.29%> (?)
grove_unit 12.02% <ø> (?)
t3c_unit 5.99% <3.31%> (?)
traffic_monitor_unit 26.33% <0.00%> (?)
traffic_ops_integration 69.38% <ø> (-0.04%) ⬇️
traffic_ops_unit 21.68% <ø> (?)
traffic_portal_v2 74.38% <74.17%> (+0.59%) ⬆️
traffic_stats_unit 10.76% <ø> (?)
unit_tests 29.25% <60.64%> (-44.53%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.49% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cache-config/t3c-apply/config/config.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/torequest/cmd.go 0.00% <0.00%> (ø)
cache-config/t3c-check-refs/t3c-check-refs.go 1.78% <0.00%> (ø)
cache-config/t3c-generate/cfgfile/varnish.go 0.00% <0.00%> (ø)
cache-config/t3c-generate/config/config.go 0.81% <0.00%> (-0.08%) ⬇️
cache-config/t3c-generate/t3c-generate.go 0.00% <ø> (ø)
experimental/traffic-portal/src/app/api/index.ts 100.00% <ø> (ø)
...mental/traffic-portal/src/app/api/testing/index.ts 100.00% <ø> (ø)
...perimental/traffic-portal/src/app/app.ui.module.ts 100.00% <ø> (ø)
...tatuses/statuses-table/statuses-table.component.ts 82.35% <ø> (ø)
... and 86 more

... and 367 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You addressed my comments already in updates, just 1 last nit about import order )

lib/go-tc/tenants.go Outdated Show resolved Hide resolved
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog looks a little weird, once that's fixed I can merge :)

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zrhoffman zrhoffman merged commit 6ca8fda into apache:master Aug 28, 2023
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium impact impacts a significant portion of a CDN, or has the potential to do so tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants