Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC3339 Fix for ProfileParameter #7745

Merged

Conversation

jagan-parthiban
Copy link
Contributor

@jagan-parthiban jagan-parthiban commented Aug 25, 2023

Related: #5911


  • Traffic Ops

What is the best way to verify this PR?

Make Api calls to Parameter 5.0

ProfileParameters to Use RFC3339 Format

{
	"response": [
		{
			"lastUpdated": "2023-08-22T09:51:03.556698+05:30",
			"profile": "test2",
			"parameter": 1070
		},
		{
			"lastUpdated": "2023-08-22T10:33:23.249862+05:30",
			"profile": "test2",
			"parameter": 1071
		}
       ]
}

PR submission checklist

@jagan-parthiban jagan-parthiban marked this pull request as ready for review August 25, 2023 17:14
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #7745 (7215600) into master (d73b065) will increase coverage by 0.94%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #7745      +/-   ##
============================================
+ Coverage     31.01%   31.96%   +0.94%     
  Complexity       98       98              
============================================
  Files           653      710      +57     
  Lines         79157    80707    +1550     
  Branches        965      965              
============================================
+ Hits          24554    25798    +1244     
- Misses        52533    52762     +229     
- Partials       2070     2147      +77     
Flag Coverage Δ
golib_unit 52.63% <ø> (ø)
grove_unit 12.02% <ø> (ø)
t3c_unit 5.99% <ø> (ø)
traffic_monitor_unit 26.33% <ø> (ø)
traffic_ops_integration 69.39% <ø> (+3.45%) ⬆️
traffic_ops_unit 21.93% <0.00%> (+0.05%) ⬆️
traffic_portal_v2 74.38% <ø> (-0.02%) ⬇️
traffic_stats_unit 10.76% <ø> (ø)
unit_tests 29.23% <0.00%> (+0.02%) ⬆️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
..._ops_golang/profileparameter/profile_parameters.go 12.90% <0.00%> (+0.33%) ⬆️

... and 59 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. Code works correctly for POST API call.

@rimashah25 rimashah25 merged commit 0c3a248 into apache:master Aug 25, 2023
81 of 83 checks passed
@jagan-parthiban jagan-parthiban deleted the improve/rfc3339-profileparameter branch September 21, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants