Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing panic seen in TM when timestamp_ms appears as float and not string #7730

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

rimashah25
Copy link
Contributor

Resolving the panic seen in a stack trace.
Aug 17 16:53:29 : panic: interface conversion: interface {} is float64, not string


Which Traffic Control components are affected by this PR?

  • Traffic Monitor

What is the best way to verify this PR?

Run unit tests and when installing TM in an environment, ensure that it starts up without a panic.

If this is a bugfix, which Traffic Control versions contained the bug?

7.0.1

PR submission checklist

@rimashah25 rimashah25 marked this pull request as ready for review August 17, 2023 18:21
@zrhoffman zrhoffman added bug something isn't working as intended Traffic Monitor related to Traffic Monitor high impact impacts the basic function, deployment, or operation of a CDN labels Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #7730 (411b048) into master (75ec56f) will decrease coverage by 35.75%.
Report is 70 commits behind head on master.
The diff coverage is 9.38%.

@@              Coverage Diff              @@
##             master    #7730       +/-   ##
=============================================
- Coverage     65.05%   29.30%   -35.75%     
  Complexity       98       98               
=============================================
  Files           314      593      +279     
  Lines         12365    74418    +62053     
  Branches        907       90      -817     
=============================================
+ Hits           8044    21808    +13764     
- Misses         3968    50531    +46563     
- Partials        353     2079     +1726     
Flag Coverage Δ
golib_unit 52.62% <37.76%> (?)
grove_unit 12.02% <ø> (?)
t3c_unit 5.99% <3.31%> (?)
traffic_monitor_unit 26.33% <0.00%> (?)
traffic_ops_unit 22.43% <5.14%> (?)
traffic_portal_v2 ?
traffic_stats_unit 10.76% <ø> (?)
unit_tests 26.04% <9.38%> (-47.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cache-config/t3c-apply/config/config.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/torequest/cmd.go 0.00% <0.00%> (ø)
cache-config/t3c-check-refs/t3c-check-refs.go 1.78% <0.00%> (ø)
cache-config/t3c-generate/cfgfile/varnish.go 0.00% <0.00%> (ø)
cache-config/t3c-generate/config/config.go 0.81% <0.00%> (-0.08%) ⬇️
cache-config/t3c-generate/t3c-generate.go 0.00% <ø> (ø)
lib/go-atscfg/parentabstraction.go 79.47% <ø> (ø)
lib/go-tc/cdns.go 0.00% <ø> (ø)
lib/go-tc/deliveryservice_servers.go 0.00% <0.00%> (ø)
lib/go-tc/federation_resolver.go 45.45% <0.00%> (ø)
... and 32 more

... and 457 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zrhoffman zrhoffman merged commit 1adfebc into apache:master Aug 17, 2023
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended high impact impacts the basic function, deployment, or operation of a CDN Traffic Monitor related to Traffic Monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants