Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SECURE-SERVER:READ capability to operations role #7712

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

zrhoffman
Copy link
Member

This PR adds the SECURE-SERVER:READ capability to operations role.


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Start Traffic Ops, check the role for the SECURE-SERVER:READ capability

PR submission checklist

@zrhoffman zrhoffman added Traffic Ops related to Traffic Ops database relating to setup/installation/structure of the Traffic Ops database improvement The functionality exists but it could be improved in some way. labels Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #7712 (d23b6ba) into master (48ec14e) will increase coverage by 35.82%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #7712       +/-   ##
=============================================
+ Coverage     29.78%   65.61%   +35.82%     
  Complexity       98       98               
=============================================
  Files           804      323      -481     
  Lines         86263    12829    -73434     
  Branches        965      965               
=============================================
- Hits          25696     8418    -17278     
+ Misses        58426     4051    -54375     
+ Partials       2141      360     -1781     
Flag Coverage Δ
golib_unit ?
grove_unit ?
t3c_unit ?
traffic_monitor_unit ?
traffic_ops_unit ?
traffic_portal_v2 74.39% <ø> (+0.01%) ⬆️
traffic_stats_unit ?
unit_tests 74.39% <ø> (+47.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 484 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Appropriately handles the migration
  • Adds it to the seeds

@shamrickus shamrickus merged commit 2e7e28e into apache:master Aug 14, 2023
24 of 25 checks passed
cybertunnel pushed a commit to cybertunnel/trafficcontrol that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database relating to setup/installation/structure of the Traffic Ops database improvement The functionality exists but it could be improved in some way. Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants