TPv2 Add Download Options Dialog to Generic Table #7472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamrickus
added
new feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7472 +/- ##
============================================
+ Coverage 65.64% 65.84% +0.19%
Complexity 98 98
============================================
Files 323 328 +5
Lines 12827 13042 +215
Branches 965 999 +34
============================================
+ Hits 8420 8587 +167
- Misses 4048 4093 +45
- Partials 359 362 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shamrickus
force-pushed
the
tpv2/download-options
branch
from
c2cd9b7
to
2078369
Compare
|
LGTM |
shamrickus
force-pushed
the
tpv2/download-options
branch
from
75b2815
to
86d77ed
Compare
|
@ntheanh201 To review the PR, go to https://github.com/apache/trafficcontrol/pull/7472/files and either approve the PR or request changes. Once it is approved, I can merge :) |
ntheanh201
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dialog to the download csv button on the TPv2 generic table. This dialog lets the user change what is downloaded including: filename, delimiter, headers, hidden columns, hidden rows, only selected rows.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Verify tests and lint pass. Go-to any table and confirm the dialog works and options are respected.
PR submission checklist