-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed reference URLs on delivery service (DNS, HTTP) pages #5027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it works for what it changes - however, HTTP and DNS Delivery Service pages in TP still have two broken references. The first is in the "Deep Caching" field's tooltip, where it should probably be https://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_router.html#deep-caching
to link to the correct anchor. The other is in the tooltip for "Geo Limit Redirect URL" and to be honest I'm not sure where that's supposed to take you.
Neither of these land on 404 pages, they're just non-existent anchors on an existent page. So you don't need to fix that if you don't want to, but I thought I'd bring it up.
I updated both these reference urls. |
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
page does not exists yet
error.If this is a bug fix, what versions of Traffic Control are affected?
master (d809e9a)
The following criteria are ALL met by this PR
Additional Information
The PR doesn't need documentation or tests since it only updates the Reference URL path in Traffic Portal. No logic has been implemented.