Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reference URLs on delivery service (DNS, HTTP) pages #5027

Merged
merged 5 commits into from
Sep 16, 2020

Conversation

rimashah25
Copy link
Contributor

@rimashah25 rimashah25 commented Sep 15, 2020

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

  1. Go to traffic_portal's create a delivery service page.
  2. Select either HTTP, or DNS type
  3. Go to section Cache Configuration Settings, and hover over every field in that section and click on the links present in help tool tip.
  4. No link should show a page does not exists yet error.

If this is a bug fix, what versions of Traffic Control are affected?

master (d809e9a)

The following criteria are ALL met by this PR

  • I have explained why tests are unnecessary
  • I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

The PR doesn't need documentation or tests since it only updates the Reference URL path in Traffic Portal. No logic has been implemented.

Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it works for what it changes - however, HTTP and DNS Delivery Service pages in TP still have two broken references. The first is in the "Deep Caching" field's tooltip, where it should probably be https://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_router.html#deep-caching to link to the correct anchor. The other is in the tooltip for "Geo Limit Redirect URL" and to be honest I'm not sure where that's supposed to take you.

Neither of these land on 404 pages, they're just non-existent anchors on an existent page. So you don't need to fix that if you don't want to, but I thought I'd bring it up.

@rimashah25
Copy link
Contributor Author

This looks like it works for what it changes - however, HTTP and DNS Delivery Service pages in TP still have two broken references. The first is in the "Deep Caching" field's tooltip, where it should probably be https://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_router.html#deep-caching to link to the correct anchor. The other is in the tooltip for "Geo Limit Redirect URL" and to be honest I'm not sure where that's supposed to take you.

Neither of these land on 404 pages, they're just non-existent anchors on an existent page. So you don't need to fix that if you don't want to, but I thought I'd bring it up.

I updated both these reference urls.

@ocket8888 ocket8888 merged commit 9d8f08a into apache:master Sep 16, 2020
@rimashah25 rimashah25 deleted the CDN-10613/reference-urls branch September 17, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference urls for Cache Config in TP are invalid
2 participants