Fix SpotBugs warning

apache · May 3, 2019 · 151b447 · 151b447
1 parent 5c026aa
commit 151b447
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java b/java/org/apache/tomcat/util/http/fileupload/disk/DiskFileItem.java
@@ -392,7 +392,10 @@ public void write(File file) throws Exception {
                  * desired file.
                  */
                 if (file.exists()) {
-                    file.delete();
+                    if (!file.delete()) {
+                        throw new FileUploadException(
+                                "Cannot write uploaded file to disk!");
+                    }
                 }
                 if (!outputFile.renameTo(file)) {
                     BufferedInputStream in = null;