Add pluggable auth in gremlin-python with HTTP #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkagamlyk
reviewed
Aug 20, 2024
vkagamlyk
reviewed
Aug 20, 2024
kenhuuu
reviewed
Aug 20, 2024
kenhuuu
reviewed
Aug 20, 2024
Cole-Greer
reviewed
Aug 20, 2024
xiazcy
force-pushed
the
python-auth
branch
2 times, most recently
from
2e2b898 to
2468754
Compare
|
VOTE +1 |
Cole-Greer
approved these changes
Aug 28, 2024
|
VOTE +1. Thanks for all the reviews! I will merge this now. |
xiazcy
added a commit
that referenced
this pull request
Aug 28, 2024
kenhuuu
pushed a commit
that referenced
this pull request
Nov 2, 2024
kenhuuu
pushed a commit
that referenced
this pull request
Nov 3, 2024
kenhuuu
pushed a commit
that referenced
this pull request
Nov 3, 2024
kenhuuu
pushed a commit
that referenced
this pull request
Nov 3, 2024
kenhuuu
pushed a commit
that referenced
this pull request
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing the Java driver, added an interface for authentication with HTTP, with basic and SigV4 auth as reference implementations. e.g.
username='stephen', password='password'is replaced byauth=basic('stephen', 'password').Local tests pass, will be updating the docker compose set-up as next step for integration tests.