TINKERPOP-2976 Fix modification while iterating #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.5-dev #2176 +/- ##
==========================================
Coverage 69.94% 69.95%
- Complexity 9027 9033 +6
==========================================
Files 866 866
Lines 41068 41068
Branches 5476 5476
==========================================
+ Hits 28726 28730 +4
Misses 10440 10440
+ Partials 1902 1898 -4 see 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vkagamlyk
reviewed
Aug 2, 2023
gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphBinary/TypeSerializerRegistry.cs
Show resolved
Hide resolved
|
VOTE +1 |
|
VOTE +1, should we have a changelog entry for this? |
Yes, you're right. This should get a changelog entry. I'll add one when I merge this. |
In rare cases users could get an InvalidOperationException if the dictionary of `_serializerByType` was modified while another thread in parallel iterated over the keys of this dictionary. Just creating a copy of the supported types and then iterating over that should fix this. The problem was reported for GraphBinary, but the GraphSONWriter had the same problem so I also fixed it there.
FlorianHockmann
force-pushed
the
TINKERPOP-2976
branch
from
01c6571 to
eda4ea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2976
In rare cases users could get an
InvalidOperationExceptionif the dictionary of_serializerByTypewas modified while another thread in parallel iterated over the keys of this dictionary. Just creating a copy of the supported types and then iterating over that should fix this.The problem was reported for GraphBinary, but the GraphSONWriter had the same problem so I also fixed it there.
VOTE +1
Since we are currently in code freeze, we can simply merge this after that has been lifted.