Skip to content

Commit

Permalink
Changed shaded java driver classifier from all to shaded.
Browse files Browse the repository at this point in the history
shaded seems like the right name for this - all might imply something else. CTR
  • Loading branch information
spmallette committed Mar 19, 2021
1 parent f5c49d2 commit 7f7d3a4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/src/reference/gremlin-variants.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ tinkergraph-gremlin which are not shaded.
<groupId>org.apache.tinkerpop</groupId>
<artifactId>gremlin-driver</artifactId>
<version>x.y.z</version>
<classifier>all</classifier>
<classifier>shaded</classifier>
<!-- The shaded JAR uses the original POM, therefore conflicts may still need resolution -->
<exclusions>
<exclusion>
Expand Down
4 changes: 2 additions & 2 deletions docs/src/upgrade/release-3.5.x.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ extensive dependency chains.
<groupId>org.apache.tinkerpop</groupId>
<artifactId>gremlin-driver</artifactId>
<version>x.y.z</version>
<classifier>all</classifier>
<classifier>shaded</classifier>
</dependency>
----
The above dependency with the `all` classifier shades all the dependencies of `gremlin-driver` and includes
The above dependency with the `shaded` classifier shades all the dependencies of `gremlin-driver` and includes
`gremlin-core` and `tinkergraph-gremlin` in an unshaded form.
See: link:https://issues.apache.org/jira/browse/TINKERPOP-2476[TINKERPOP-2476]
Expand Down
2 changes: 1 addition & 1 deletion gremlin-driver/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ limitations under the License.
<shadeSourcesContent>true</shadeSourcesContent>
<createSourcesJar>true</createSourcesJar>
<shadedArtifactAttached>true</shadedArtifactAttached>
<shadedClassifierName>all</shadedClassifierName>
<shadedClassifierName>shaded</shadedClassifierName>
<artifactSet>
<!-- exclude logging stuff from uberjar - shading prevents proper logger initialization -->
<excludes>
Expand Down

0 comments on commit 7f7d3a4

Please sign in to comment.