Skip to content

Commit

Permalink
THRIFT-5338: Remove lib/go/thrift/go.mod
Browse files Browse the repository at this point in the history 
Client: go

Having it under a subdirectory has some unexpected consequences, so
remove it for now. Another PR will be open up later to add it back to
the root directory.
  • Loading branch information
@fishy
fishy committed Jan 20, 2021
1 parent e27e82c commit d9fcdd3
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions lib/go/thrift/go.mod
View file

This file was deleted.

2 comments on commit d9fcdd3

@Gemini-Lin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you forget to add it back to the root directory? My project use this commit ,and it has go.mod file . When I used go mod tidy command to manage dependencies, there was a error like:

        ambiguous import: found package github.com/apache/thrift/lib/go/thrift in multiple modules:
	github.com/apache/thrift v0.13.0 (/go/pkg/mod/github.com/apache/[email protected]/lib/go/thrift)
	github.com/apache/thrift/lib/go/thrift v0.0.0-20210120171102-e27e82c46ba4 (/go/pkg/mod/github.com/apache/thrift/lib/go/[email protected])

So maybe you can write a go.mod in the root directory like:

module github.com/apache/thrift

go 1.14

require github.com/apache/thrift/lib/go/thrift v0.14.2

@Gemini-Lin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry about it, I have found go.mod in the root directory.

Please sign in to comment.