Skip to content

Commit

Permalink
Github Actions: Remove --disable-tests
Browse files Browse the repository at this point in the history
With --disable-tests, for example for Go the `make check` under `lib/go`
would only run unit tests under `lib/go/thrift` but not the unit tests
under `lib/go/test`.
  • Loading branch information
fishy committed Nov 22, 2023
1 parent a06eedc commit 4b9be1a
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 33 deletions.
1 change: 0 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ env:
BUILD_DEPS: automake bison flex git libboost-all-dev libevent-dev libssl-dev libtool make pkg-config
CONFIG_ARGS_FOR_LIBS: >
--disable-debug
--disable-tests
--disable-dependency-tracking
--without-cpp
--without-c_glib
Expand Down
2 changes: 2 additions & 0 deletions lib/go/test/fuzz/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
go.mod
go.sum
11 changes: 7 additions & 4 deletions lib/go/test/fuzz/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,16 @@ gopathfuzz: $(THRIFT) fuzz.go
touch gopathfuzz

check: gopathfuzz
go mod init github.com/apache/thrift/lib/go/test/fuzz
go mod edit --replace github.com/apache/thrift=../../../../
go mod edit --replace shared=./gen-go/shared
go mod edit --replace tutorial=./gen-go/tutorial
go mod tidy
go test -tags gofuzz

clean-local:
$(RM) -r gopathfuzz gen-go
$(RM) -rf gopathfuzz gen-go go.mod go.sum

EXTRA_DIST = \
fuzz.go \
fuzz_test.go \
go.mod \
go.sum
fuzz_test.go
15 changes: 0 additions & 15 deletions lib/go/test/fuzz/go.mod

This file was deleted.

13 changes: 0 additions & 13 deletions lib/go/test/fuzz/go.sum

This file was deleted.

0 comments on commit 4b9be1a

Please sign in to comment.