THRIFT-5350 char is unsigned on non-x86 arches, use signed char to av…

…oid compiler warning about always true comparisons Patch: Orion Poplawski This closes #2331
apache · Feb 17, 2021 · 36bd59f · 36bd59f
1 parent 055fe67
commit 36bd59f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/compiler/cpp/src/thrift/generate/t_delphi_generator.cc b/compiler/cpp/src/thrift/generate/t_delphi_generator.cc
@@ -1062,7 +1062,7 @@ std::string t_delphi_generator::make_pascal_string_literal(std::string value) {
   }
 
   result << "'";
-  for (char const &c: value) {
+  for (signed char const c: value) {
     if( (c >= 0) && (c < 32)) {  // convert ctrl chars, but leave UTF-8 alone
       result << "#" << (int)c;  
     } else if (c == '\'') {