FilterBox,BigNumber,WorldMap: Handle empty results #9671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change avoids Pandas errors to pop up in chart when no data is returned (confusing users). In this way a nicer "No Results etc.." is returned.
Codecov Report
@@ Coverage Diff @@
## master #9671 +/- ##
==========================================
- Coverage 70.53% 70.53% -0.01%
==========================================
Files 581 581
Lines 30224 30230 +6
Branches 3078 3078
==========================================
+ Hits 21319 21322 +3
- Misses 8793 8796 +3
Partials 112 112
Continue to review full report at Codecov.
|
|
@mistercrunch if you have time for a quick review I'd be super grateful :) |
|
Could you show the old + new screenshots side by side in the test plan? thanks! |
Added, hope it is what you asked, otherwise let me know! |
graceguo-supercat
pushed a commit
that referenced
this pull request
May 6, 2020
graceguo-supercat
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
May 6, 2020
…)" (apache#9755) This reverts commit 865a909. (cherry picked from commit 4b6681b)
elukey
added a commit
to elukey/incubator-superset
that referenced
this pull request
May 12, 2020
This change was originally attempted in apache#9671 but reverted since it broke FilterBox charts with only a time selector. After some tests I reworked the patch to avoid returning None, but instead returning an empty list for each col/selector with an empty dataframe associated. This allows to see all the selectors without any breakage.
12 tasks
bkyryliuk
pushed a commit
to bkyryliuk/incubator-superset
that referenced
this pull request
May 13, 2020
…)" (apache#9755) This reverts commit 865a909.
etr2460
pushed a commit
that referenced
this pull request
May 17, 2020
…9789) * FilteBox: handle empty results (second attempt) This change was originally attempted in #9671 but reverted since it broke FilterBox charts with only a time selector. After some tests I reworked the patch to avoid returning None, but instead returning an empty list for each col/selector with an empty dataframe associated. This allows to see all the selectors without any breakage. * BigNumberViz: avoid user facing errors when the dataframe is empty * WorldMapViz: avoid user facing errors when the dataframe is empty
wmfgerrit
pushed a commit
to wikimedia/analytics-superset-deploy
that referenced
this pull request
May 22, 2020
The version built is not the one that comes straight from Pypi, but I have backported apache/superset#9468 and apache/superset#9671. The bugs are minor ones, in fact it didn't stop the release process when reported, so even using the version from pypi leads to a workable result (just less nice to see in certain corner cases). Bug: T249495 Change-Id: I671ac04fb52c3dc1241f686f37caa21ce097090a
wmfgerrit
pushed a commit
to wikimedia/analytics-superset-deploy
that referenced
this pull request
May 27, 2020
The version built is not the one that comes straight from Pypi, but I have backported apache/superset#9468 and apache/superset#9671. The bugs are minor ones, in fact it didn't stop the release process when reported, so even using the version from pypi leads to a workable result (just less nice to see in certain corner cases). Bug: T249495 Change-Id: I8084a0f38c6c458bbaac8c03d158a062e830a678
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids Pandas errors to pop up in chart when no data
is returned (confusing users). In this way a nicer "No Results etc.." is returned.
CATEGORY
Choose one
SUMMARY
Add some checks to avoid Pandas errors to bubble up to the users.
TEST PLAN
Using "legacy" Druid datasources and setting charts to return no data.
Before the fix:
After:
ADDITIONAL INFORMATION
None
REVIEWERS