-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add geospatial post processing operations #9661
feat: Add geospatial post processing operations #9661
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
+ Coverage 64.03% 70.54% +6.51%
==========================================
Files 532 581 +49
Lines 28897 30272 +1375
Branches 2758 3072 +314
==========================================
+ Hits 18503 21355 +2852
+ Misses 10211 8805 -1406
+ Partials 183 112 -71
Continue to review full report at Codecov.
|
@ktmud The change will require a slightly bigger refactor. I'll do this as a separate PR later to keep this PR simple. In the meantime you can do the select and rename by applying two consecutive selects; first renaming, next selecting. This will only cause negligible overhead, hence it might even be a better idea to split out all operations from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of non blocking comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the test def name should be changed
Thanks for the valuable comments @dpgaspar ! |
CATEGORY
Choose one
SUMMARY
Add geospatial post processing operations to new chart data endpoint.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS