Controls cleanup pass #9578
Merged
Controls cleanup pass #9578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9578 +/- ##
=======================================
Coverage 65.64% 65.64%
=======================================
Files 581 581
Lines 30192 30192
Branches 3071 3071
=======================================
Hits 19820 19820
Misses 10191 10191
Partials 181 181
Continue to review full report at Codecov.
|
rusackas
force-pushed
the
controls-cleanup-pass
branch
from
d9ebef9 to
5a2936a
Compare
12 tasks
nytai
pushed a commit
to preset-io/superset
that referenced
this pull request
Jun 10, 2020
* migrating date_filter * normalized control * filter_configs control * column_collection control * time_range_endpoints control * time_range_fixed control * url_params control * cache_timeout control * annotation_layers control * color control unused? * linters rule 🤘 * this should have been deleted earlier * global_opacity, mapbox_label, mapbox_style, viewport_zoom * linting * comparison_type * contribution control * log_scale * show_values * table_filter * pandas_aggfunc * code control * formatSelectOptions import * lint * markup_type control * lintage * date_time_format control, linting * url control, test mods * min_periods control * rolling_periods * rolling_type * missing lib * order_desc * number_format * link_length * all_columns_y * all_columns_x * normalize_across, select_country, all_columns * fixing test * linter-caught dependencies * waiting * wait longer! * utilizing tabOverride for Analytics * tabOverride for Annotations and Layers
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Removing more controls from
controls.jsxBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@suddjian @ktmud @villebro @kristw