Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Nigeria to countries controls list. #9485

Conversation

MarcusSorealheis
Copy link
Contributor

@MarcusSorealheis MarcusSorealheis commented Apr 7, 2020

CATEGORY

simple UI update.

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Quickly added s user's country (Nigeria) to the controls list per request by a guy in Slack. He's working on Covid reporting for Nigeria.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

None at this time.

ADDITIONAL INFORMATION

This PR may not be the solution to his problem. Only trying to help. I thought I opened this PR already but I guess I didn't.

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@codecov-io
Copy link

Codecov Report

Merging #9485 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9485      +/-   ##
==========================================
- Coverage   59.01%   58.76%   -0.25%     
==========================================
  Files         383      385       +2     
  Lines       12191    12237      +46     
  Branches     3014     3020       +6     
==========================================
- Hits         7194     7191       -3     
- Misses       4813     4862      +49     
  Partials      184      184              
Impacted Files Coverage Δ
superset-frontend/src/explore/controls.jsx 42.85% <ø> (-0.12%) ⬇️
...et-frontend/src/explore/controlPanels/DeckMulti.js 0.00% <0.00%> (ø)
...-frontend/src/explore/controlPanels/DeckGeojson.js 0.00% <0.00%> (ø)
...-frontend/src/explore/controlPanels/DeckScatter.js 0.00% <0.00%> (ø)
...rset-frontend/src/explore/controlPanels/DeckArc.js 0.00% <0.00%> (ø)
...ontend/src/explore/controlPanels/Shared_DeckGL.jsx 0.00% <0.00%> (ø)
...rontend/src/explore/components/PropertiesModal.tsx 13.23% <0.00%> (+0.53%) ⬆️
...ntend/src/dashboard/components/PropertiesModal.jsx 48.00% <0.00%> (+2.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e38f6...7405558. Read the comment docs.

@MarcusSorealheis
Copy link
Contributor Author

MarcusSorealheis commented Apr 8, 2020

I'm closing this PR because I asked him to simply type it in and that should work well enough. My apologies for not thinking about this before when he first asked me.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants