Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty dataframes in TableViz #9471

Closed
wants to merge 1 commit into from
Closed

Conversation

elukey
Copy link
Contributor

@elukey elukey commented Apr 5, 2020

TableViz fails to display empty dataframes returning an error like:
"None of [Index(['project', 'count'], dtype='object')] are in the [columns]"

The behavior has been observed while testing 0.36.0rc3 with
Druid datasources.

Fixes: #9468

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elukey ! LGTM, I restarted the build as Travis apparently got stuck again.

@elukey
Copy link
Contributor Author

elukey commented Apr 6, 2020

Thanks @elukey ! LGTM, I restarted the build as Travis apparently got stuck again.

Np! Happy to help :) Travis seems green if I follow the link, but the PR is still waiting..

@villebro
Copy link
Member

villebro commented Apr 6, 2020

Hmm, it's still not updating. @elukey can you rebase and force push to kickstart CI again?

TableViz fails to display empty dataframes returning an error like:
"None of [Index(['project', 'count'], dtype='object')] are in the [columns]"

The behavior has been observed while testing 0.36.0rc3 with
Druid datasources.

issue: apache#9468
@elukey
Copy link
Contributor Author

elukey commented Apr 6, 2020

Hmm, it's still not updating. @elukey can you rebase and force push to kickstart CI again?

Retried, and the build failed for some temporary issue (The command "nvm install 10.14.2" failed and exited with 1 during .) but it shows as not completed, not sure what is happening..

@elukey
Copy link
Contributor Author

elukey commented Apr 6, 2020

Let me try to close this and re-open, maybe it helps :)

@elukey elukey closed this Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TableViz regression when displaying no data for a Druid datasource in 0.36.0rc3
2 participants