-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirgrating unique Partition chart controls #9385
Merged
rusackas
merged 2 commits into
apache:master
from
preset-io:migrating-unique-Partition-controls
Mar 27, 2020
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
151 changes: 151 additions & 0 deletions
151
superset-frontend/src/explore/controlPanels/Partition.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,151 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import React from 'react'; | ||
| import { t } from '@superset-ui/translation'; | ||
| import { NVD3TimeSeries } from './sections'; | ||
| import OptionDescription from '../../components/OptionDescription'; | ||
| import * as v from '../validators'; | ||
|
|
||
| export default { | ||
| controlPanelSections: [ | ||
| NVD3TimeSeries[0], | ||
| { | ||
| label: t('Time Series Options'), | ||
| expanded: true, | ||
| controlSetRows: [ | ||
| [ | ||
| { | ||
| name: 'time_series_option', | ||
| config: { | ||
| type: 'SelectControl', | ||
| label: t('Options'), | ||
| validators: [v.nonEmpty], | ||
| default: 'not_time', | ||
| valueKey: 'value', | ||
| options: [ | ||
| { | ||
| label: t('Not Time Series'), | ||
| value: 'not_time', | ||
| description: t('Ignore time'), | ||
| }, | ||
| { | ||
| label: t('Time Series'), | ||
| value: 'time_series', | ||
| description: t('Standard time series'), | ||
| }, | ||
| { | ||
| label: t('Aggregate Mean'), | ||
| value: 'agg_mean', | ||
| description: t('Mean of values over specified period'), | ||
| }, | ||
| { | ||
| label: t('Aggregate Sum'), | ||
| value: 'agg_sum', | ||
| description: t('Sum of values over specified period'), | ||
| }, | ||
| { | ||
| label: t('Difference'), | ||
| value: 'point_diff', | ||
| description: t( | ||
| 'Metric change in value from `since` to `until`', | ||
| ), | ||
| }, | ||
| { | ||
| label: t('Percent Change'), | ||
| value: 'point_percent', | ||
| description: t( | ||
| 'Metric percent change in value from `since` to `until`', | ||
| ), | ||
| }, | ||
| { | ||
| label: t('Factor'), | ||
| value: 'point_factor', | ||
| description: t( | ||
| 'Metric factor change from `since` to `until`', | ||
| ), | ||
| }, | ||
| { | ||
| label: t('Advanced Analytics'), | ||
| value: 'adv_anal', | ||
| description: t('Use the Advanced Analytics options below'), | ||
| }, | ||
| ], | ||
| optionRenderer: op => <OptionDescription option={op} />, | ||
| valueRenderer: op => <OptionDescription option={op} />, | ||
| description: t('Settings for time series'), | ||
| }, | ||
| }, | ||
| ], | ||
| ], | ||
| }, | ||
| { | ||
| label: t('Chart Options'), | ||
| expanded: true, | ||
| controlSetRows: [ | ||
| ['color_scheme', 'label_colors'], | ||
| ['number_format', 'date_time_format'], | ||
| [ | ||
| { | ||
| name: 'partition_limit', | ||
| config: { | ||
| type: 'TextControl', | ||
| label: t('Partition Limit'), | ||
| isInt: true, | ||
| default: '5', | ||
| description: t( | ||
| 'The maximum number of subdivisions of each group; ' + | ||
| 'lower values are pruned first', | ||
| ), | ||
| }, | ||
| }, | ||
| { | ||
| name: 'partition_threshold', | ||
| config: { | ||
| type: 'TextControl', | ||
| label: t('Partition Threshold'), | ||
| isFloat: true, | ||
| default: '0.05', | ||
| description: t( | ||
| 'Partitions whose height to parent height proportions are ' + | ||
| 'below this value are pruned', | ||
| ), | ||
| }, | ||
| }, | ||
| ], | ||
| [ | ||
| 'log_scale', | ||
| { | ||
| name: 'equal_date_size', | ||
| config: { | ||
| type: 'CheckboxControl', | ||
| label: t('Equal Date Sizes'), | ||
| default: true, | ||
| renderTrigger: true, | ||
| description: t( | ||
| 'Check to force date partitions to have the same height', | ||
| ), | ||
| }, | ||
| }, | ||
| ], | ||
| ['rich_tooltip'], | ||
| ], | ||
| }, | ||
| NVD3TimeSeries[1], | ||
| ], | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also refactor to do specific imports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely.