Bump pandas to 0.25.3

[villebro]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

On the "What’s new in 1.0.0 (??)" page https://dev.pandas.io/docs/whatsnew/v1.0.0.html , the following is stated: "It is recommended to first upgrade to pandas 0.25 and to ensure your code is working without warnings, before upgrading to pandas 1.0." As Superset is still on 0.24, it makes sense to bump to 0.25 now, as 1.0 is currently nearing release.

Bumping required a small change in superset.result_set.py due to Pandas now being more explicit about timezones. The new logic in 0.25 caused the original datetimes to be shifted by the UTC offset, as they were interpreted as being UTC due to the missing tzinfo. I traced back the change to this PR: pandas-dev/pandas#25263

[codecov-io]

Codecov Report

Merging #8985 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8985   +/-   ##
=======================================
  Coverage   59.16%   59.16%           
=======================================
  Files         367      367           
  Lines       11679    11679           
  Branches     2862     2862           
=======================================
  Hits         6910     6910           
  Misses       4590     4590           
  Partials      179      179

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fc5fd4...21c30f7. Read the comment docs.

[villebro]

@robdiciuccio , as this touches code that you recently changed, it would be great if you could take a look at this PR.

[robdiciuccio]

@villebro getting the following error when loading data from a timestamptz column in postgres:

ERROR:root:Already tz-aware, use tz_convert to convert.
Traceback (most recent call last):
  File "/Users/rob/work/incubator-superset/superset/result_set.py", line 96, in __init__
    series = pd.to_datetime(series).dt.tz_localize(tz)
  File "/Users/rob/work/incubator-superset/venv/lib/python3.6/site-packages/pandas/core/accessor.py", line 91, in f
    return self._delegate_method(name, *args, **kwargs)
  File "/Users/rob/work/incubator-superset/venv/lib/python3.6/site-packages/pandas/core/indexes/accessors.py", line 94, in _delegate_method
    result = method(*args, **kwargs)
  File "/Users/rob/work/incubator-superset/venv/lib/python3.6/site-packages/pandas/core/accessor.py", line 91, in f
    return self._delegate_method(name, *args, **kwargs)
  File "/Users/rob/work/incubator-superset/venv/lib/python3.6/site-packages/pandas/core/indexes/datetimelike.py", line 721, in _delegate_method
    result = operator.methodcaller(name, *args, **kwargs)(self._data)
  File "/Users/rob/work/incubator-superset/venv/lib/python3.6/site-packages/pandas/core/arrays/datetimes.py", line 1049, in tz_localize
    raise TypeError("Already tz-aware, use tz_convert to convert.")
TypeError: Already tz-aware, use tz_convert to convert.

EDIT: scratch that, newer version of Pandas was not loaded 🤦‍♂

[robdiciuccio]

LGTM, tested against Postgres timestamp with time zone columns.

[villebro]

Thanks for testing @robdiciuccio . I also verified that this works with both timestamp and timestamptz on Postgres and a few other dbs, so I believe this is good to go.

[villebro]

I'm going to go ahead and merge this, and I haven't been able to turn up any regressions through regular use. If this does surface regressions, I will give priority to fix the errors + unit tests.