Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] superset-ui-plugins linking tool for local development #8638

Closed
wants to merge 19 commits into from
Closed

[wip] superset-ui-plugins linking tool for local development #8638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
dcd9414
npm run packages-dev-start to link superset-ui-plugins
rusackas Nov 22, 2019
e827db4
webpack config to automatically alias linked plugins
suddjian Nov 23, 2019
f20e05c
license
suddjian Nov 25, 2019
64ea2fd
rewrite imports only if plugins repo directory exists
suddjian Nov 25, 2019
735d1a6
lint
suddjian Nov 25, 2019
9bbe40c
document plugin devmode
suddjian Dec 5, 2019
b604767
make it prettier
suddjian Dec 6, 2019
6e828c9
moving an essential file
rusackas Mar 12, 2020
5939c91
updated package lock
rusackas Mar 12, 2020
7e7df06
simple doc updates
rusackas Mar 12, 2020
b1a759e
fixing default path after superset-frontend move
rusackas Mar 12, 2020
da45f7b
explicitly disabling all packages but the treemap, just to narrow bug…
rusackas Mar 12, 2020
efd14c7
Update package-lock.json
rusackas Mar 18, 2020
c7162f4
fixing duplicate requirement
rusackas Mar 18, 2020
0183f22
removing unnecessary blacklist items. They work!
rusackas Mar 18, 2020
ba4898c
appeasing the linting gods
rusackas Mar 18, 2020
43e7ac9
typo!
rusackas Mar 18, 2020
658c657
fixing some scripts that got mis-merged.
rusackas Mar 19, 2020
2de431f
linting
rusackas Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,12 @@ Here's an example as a Github PR with comments that describe what the
different sections of the code do:
https://github.com/apache/incubator-superset/pull/3013

To run Superset using visualization plugins from your local machine, run `npm run plugin-devmode-on`. This will use `npm link` to connect the Superset frontend to your local copy of [superset-ui-plugins](https://github.com/apache-superset/superset-ui-plugins). This command uses the environment variable `SUPERSET_UI_PLUGINS_PATH` to determine the path, defaulting to `../superset-ui-plugins`. So, for example, if the path to your local `superset-ui-plugins` repo, relative to `incubator-superset`, happens to be `../../my-fork-of-superset-ui-plugins`, then run `SUPERSET_UI_PLUGINS_PATH=../../my-fork-of-superset-ui-plugins npm run plugin-devmode-on`

This `SUPERSET_UI_PLUGINS_PATH` is also required by webpack when running the frontend with symlinked vis packages, so when starting the dev server, run it with (using the above example path) `SUPERSET_UI_PLUGINS_PATH=../../my-fork-of-superset-ui-plugins npm run dev`

Run `npm run plugin-devmode-off` to undo the linking.

### Adding a DB migration

1. Alter the model you want to change. This example will add a `Column` Annotations model.
Expand Down
Loading