Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Now with CSS sourcemaps! #8637

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Now with CSS sourcemaps! #8637

merged 1 commit into from
Nov 26, 2019

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Nov 23, 2019 •
edited
Loading

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Adds CSS sourcemaps to make editing CSS less painful.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

Reviewers:
@mistercrunch @etr2460

@codecov-io
Copy link

codecov-io commented Nov 23, 2019 •
edited
Loading

Codecov Report

Merging #8637 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8637   +/-   ##
=======================================
  Coverage   65.78%   65.78%           
=======================================
  Files         482      482           
  Lines       23814    23814           
  Branches     2589     2589           
=======================================
  Hits        15667    15667           
  Misses       7978     7978           
  Partials      169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c83c64...9fe838a. Read the comment docs.

@rusackas rusackas changed the title now with sourcemaps! Now with CSS sourcemaps! Nov 25, 2019
@mistercrunch mistercrunch merged commit badcf82 into apache:master Nov 26, 2019
@mistercrunch mistercrunch deleted the css-sourcemaps branch November 26, 2019 18:09
@mistercrunch mistercrunch mentioned this pull request Dec 2, 2019
Closed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.36.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rusackas @codecov-io @graceguo-supercat @mistercrunch @dpgaspar