Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard scoped filters] Add all time related options to filters initialization #8636

Merged

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Nov 23, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Time filter has a few checkbox options:

  • Show SQL Granularity Dropdown
  • Show SQL Time Column
  • Show Druid Granularity Dropdown
  • Show Druid Time Origin

Screen Shot 2019-11-22 at 4 50 32 PM

In #8590 it is not handled in the scoped filters settings. so when user change one option from dashboard, it will throw js errors:
Screen Shot 2019-11-22 at 4 44 32 PM

User also reported a bug that if they set a value for Time Granularity field, it is not get pre-populated into filter box.

These 2 issues have same root cause: We need to map and initialize those options during dashboard initialization.

TEST PLAN

manual test

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@etr2460 @michellethomas

@graceguo-supercat graceguo-supercat changed the title [dashboard scoped filters] Add all time related options to filter scoped settings [dashboard scoped filters] Add all time related options to dashboard filters initialization Nov 23, 2019
@graceguo-supercat graceguo-supercat changed the title [dashboard scoped filters] Add all time related options to dashboard filters initialization [dashboard scoped filters] Add all time related options to filters initialization Nov 23, 2019
@codecov-io
Copy link

codecov-io commented Nov 23, 2019

Codecov Report

Merging #8636 into master will decrease coverage by 0.06%.
The diff coverage is 26.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8636      +/-   ##
==========================================
- Coverage   65.78%   65.71%   -0.07%     
==========================================
  Files         482      482              
  Lines       23814    23824      +10     
  Branches     2589     2594       +5     
==========================================
- Hits        15667    15657      -10     
- Misses       7978     7994      +16     
- Partials      169      173       +4
Impacted Files Coverage Δ
.../assets/src/visualizations/FilterBox/FilterBox.jsx 5.93% <100%> (ø) ⬆️
...ssets/src/dashboard/util/activeDashboardFilters.js 90.38% <50%> (-1.78%) ⬇️
...src/dashboard/util/getFilterConfigsFromFormdata.js 42.85% <9.09%> (-32.15%) ⬇️
superset/db_engine_specs/postgres.py 55.55% <0%> (-27.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c83c64...2b3f1a3. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit acf0753 into apache:master Nov 25, 2019
graceguo-supercat pushed a commit to airbnb/superset-fork that referenced this pull request Nov 25, 2019
@graceguo-supercat graceguo-supercat deleted the gg-FixTimeGranularity branch February 10, 2020 04:20
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants