Font styling consolidation #8633
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8633 +/- ##
=======================================
Coverage 65.75% 65.75%
=======================================
Files 482 482
Lines 23825 23825
Branches 2594 2594
=======================================
Hits 15667 15667
Misses 7985 7985
Partials 173 173
Continue to review full report at Codecov.
|
| @@ -17,7 +17,7 @@ | |||
| "build": "cross-env NODE_OPTIONS=--max_old_space_size=8192 NODE_ENV=production webpack --mode=production --colors --progress", | |||
| "lint": "eslint --ignore-path=.eslintignore --ext .js,.jsx . && tslint -c tslint.json ./{src,spec}/**/*.ts{,x}", | |||
| "lint-fix": "eslint --fix --ignore-path=.eslintignore --ext .js,.jsx . && tslint -c tslint.json --fix ./{src,spec}/**/*.ts{,x} && npm run clean-css", | |||
| "clean-css": "prettier --write src/**/*.{css,less,sass,scss}", | |||
| "clean-css": "prettier --write 'src/**/*.{css,less,sass,scss}'", | |||
There was a problem hiding this comment.
does a linter catch if css isn't formatted properly with this?
There was a problem hiding this comment.
Not at this point... was just using it to make life easier and catch myself. Does your Prettier PR address that? Don't want to duplicate effort here :)
I added a couple screenshots to the overview at the top. The most noticeable bits are that the dashboard title shrunk a teensy bit, and in-widget There were a couple instances of a font being set to 15px in size, which I would track down and bump to the standardized sizes of 14px or 16px, whichever looked more consistent in context. I think the changes were negligible, but I may be able to track them all down and add the various screenshots if anyone is particularly nervous about it. |
|
can you also paste a screenshot of active and inactive button? |
Hi @graceguo-supercat :) I added some of the main buttons in the description above. There are slight color discrepancies, but those I believe are addressed in another PR. Let me know if there are other buttons/features you'd like to see, but I believe the visible impact of this PR is pretty tiny. |
|
@etr2460 would you mind taking another look at this one? If there's nothing objectionable in here, I'd love to sneak it in before the big Prettier PR ;) |
mistercrunch
added
🏷️ bot
CATEGORY
Choose one
SUMMARY
This PR is attempting to align/consolidate the basic stylistic parameters of typography for Superset, using variables to provide font weights, font sizes, and line heights.
A few bits of unused CSS were also cleaned up in here. A few lingering colors were also brought in line with the new color variables as well.
Some compromises were made nudging a size this way or that, but the general look and feel of the UI should remain essentially unchanged.
SCREENSHOTS
A couple of header sizes, like above the illustration of the babies, and the title of the dashboard, seen here, are probably the most egregious size changes. Most everything else should be relatively unnoticeable, to the best of my knowledge/ability.
Old:
New:
Old:
New:
Old:
New:
Old:
New:
REVIEWERS
@mistercrunch @etr2460