Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent Dashboard refresh settings. #814

Conversation

alanmcruickshank
Copy link
Contributor

Revision of #718
Also resolves #686

Dashboard refresh settings persist and option to set whether to use cache or not when fetching fresh data.

Required a fix of migration 27ae655e4247 to avoid problems with referencing models which weren't up to date yet. Have moved to declarative base.

New pull request because the history of the previous one was getting really tangled.

@coveralls
Copy link

coveralls commented Jul 24, 2016

Coverage Status

Coverage increased (+0.02%) to 81.035% when pulling 6d9c45f2975f5e0daea2c9ceb8bd01e2aa4fd695 on alanmcruickshank:autorefresh-dashboard-4 into 2425b8f on airbnb:master.

@alanmcruickshank
Copy link
Contributor Author

@mistercrunch I've rebased the changes up to the most recent master. I've noticed you've not merged this change in before, have you got questions/concerns about it? I'd love to get this into the next release, so let me know what you'd need to see for us to be able to do that.

@coveralls
Copy link

coveralls commented Aug 2, 2016

Coverage Status

Coverage increased (+0.02%) to 81.516% when pulling c912643 on alanmcruickshank:autorefresh-dashboard-4 into aaef338 on airbnb:master.

@mistercrunch
Copy link
Member

Sorry this never made it in, I'm cleaning up older PRs with merge conflicts at the moment. Please resubmit the PR if you want this feature to make it in.

@dmigo
Copy link
Contributor

dmigo commented Jan 8, 2018

@alanmcruickshank was this one working? What was the impediment that prevented it from being merged?

@alanmcruickshank
Copy link
Contributor Author

@dmigo It was working - but that was before at least one refactor of the dashboard (possibly many). I reckon some of this might still be salvageable but it would need some work.

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
Bumps [react-table](https://github.com/tannerlinsley/react-table) from 7.2.1 to 7.6.1.
- [Release notes](https://github.com/tannerlinsley/react-table/releases)
- [Changelog](https://github.com/tannerlinsley/react-table/blob/master/CHANGELOG.md)
- [Commits](TanStack/table@v7.2.1...v7.6.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
Bumps [react-table](https://github.com/tannerlinsley/react-table) from 7.2.1 to 7.6.1.
- [Release notes](https://github.com/tannerlinsley/react-table/releases)
- [Changelog](https://github.com/tannerlinsley/react-table/blob/master/CHANGELOG.md)
- [Commits](TanStack/table@v7.2.1...v7.6.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
Bumps [react-table](https://github.com/tannerlinsley/react-table) from 7.2.1 to 7.6.1.
- [Release notes](https://github.com/tannerlinsley/react-table/releases)
- [Changelog](https://github.com/tannerlinsley/react-table/blob/master/CHANGELOG.md)
- [Commits](TanStack/table@v7.2.1...v7.6.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
Bumps [react-table](https://github.com/tannerlinsley/react-table) from 7.2.1 to 7.6.1.
- [Release notes](https://github.com/tannerlinsley/react-table/releases)
- [Changelog](https://github.com/tannerlinsley/react-table/blob/master/CHANGELOG.md)
- [Commits](TanStack/table@v7.2.1...v7.6.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard Auto Refresh Efficiency (settings and caching)
4 participants