Bump nvd3 chart plugin #7932
Merged
Bump nvd3 chart plugin #7932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khtruong
approved these changes
Jul 26, 2019
mistercrunch
approved these changes
Jul 27, 2019
etr2460
force-pushed
the
erik-ritter--bump-nvd3-charts
branch
from
62af891
to
5b41a49
Compare
etr2460
force-pushed
the
erik-ritter--bump-nvd3-charts
branch
from
5b41a49
to
d1e5c99
Compare
Codecov Report
@@ Coverage Diff @@
## master #7932 +/- ##
=======================================
Coverage 65.97% 65.97%
=======================================
Files 468 468
Lines 22303 22303
Branches 2429 2429
=======================================
Hits 14714 14714
Misses 7468 7468
Partials 121 121Continue to review full report at Codecov.
|
etr2460
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 29, 2019
12 tasks
etr2460
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 30, 2019
Bump nvd3 chart plugin (apache#7932)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Fixes a few more things with the responsive y axis and y domain bounds, specifically the behavior when only one bound is defined. See more details at apache-superset/superset-ui-plugins#148
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See apache-superset/superset-ui-plugins#148
TEST PLAN
See apache-superset/superset-ui-plugins#148
ADDITIONAL INFORMATION
REVIEWERS
@khtruong @williaster @kristw @graceguo-supercat