Autocomplete in the table browser in SQL lab is broken

[khtruong]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

The autocomplete in the table browser in SQL lab does not work. We use the createFilterOptions API from the react-select-fast-filter-options library for autocomplete. The API expects a list of option objects where its properties value and label are strings. The bug is that we were passing objects to the property value, which caused the algorithm to not work properly. Now we explicitly pass strings to the API.

TEST PLAN

Manually verified

REVIEWERS

@betodealmeida @DiggidyDave @xtinec

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@7a575ce). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #7736   +/-   ##
=========================================
  Coverage          ?   65.78%           
=========================================
  Files             ?      459           
  Lines             ?    21925           
  Branches          ?     2410           
=========================================
  Hits              ?    14424           
  Misses            ?     7380           
  Partials          ?      121

Impacted Files	Coverage Δ
superset/assets/src/components/TableSelector.jsx	84.8% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a575ce...f764072. Read the comment docs.

[betodealmeida]

Awesome!