Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Truncate progressbar percentage decimals (#7499) #7517

Merged
merged 1 commit into from
May 15, 2019

Conversation

bearcage
Copy link
Contributor

RETARGET OF #7499 ON lyft-develop

This change makes the query progress bar only show
whole number percentage changes, instead of numbers
like 12.13168276%.

This change makes the query progress bar only show
whole number percentage changes, instead of numbers
like 12.13168276%.
@codecov-io
Copy link

Codecov Report

Merging #7517 into lyft-develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##           lyft-develop    #7517   +/-   ##
=============================================
  Coverage         65.43%   65.43%           
=============================================
  Files               432      432           
  Lines             21319    21319           
  Branches           2347     2347           
=============================================
  Hits              13951    13951           
  Misses             7252     7252           
  Partials            116      116
Impacted Files Coverage Δ
...uperset/assets/src/SqlLab/components/ResultSet.jsx 80% <ø> (ø) ⬆️
...perset/assets/src/SqlLab/components/QueryTable.jsx 59.25% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda1002...d396fc6. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented May 15, 2019

Codecov Report

Merging #7517 into lyft-develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##           lyft-develop    #7517   +/-   ##
=============================================
  Coverage         65.43%   65.43%           
=============================================
  Files               432      432           
  Lines             21319    21319           
  Branches           2347     2347           
=============================================
  Hits              13951    13951           
  Misses             7252     7252           
  Partials            116      116
Impacted Files Coverage Δ
...uperset/assets/src/SqlLab/components/ResultSet.jsx 80% <ø> (ø) ⬆️
...perset/assets/src/SqlLab/components/QueryTable.jsx 59.25% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda1002...d396fc6. Read the comment docs.

@betodealmeida
Copy link
Member

+1

@betodealmeida betodealmeida merged commit bfa5250 into apache:lyft-develop May 15, 2019
bearcage pushed a commit to bearcage/incubator-superset that referenced this pull request May 15, 2019
…#7517)

This change makes the query progress bar only show
whole number percentage changes, instead of numbers
like 12.13168276%.
xtinec pushed a commit that referenced this pull request May 15, 2019
This change makes the query progress bar only show
whole number percentage changes, instead of numbers
like 12.13168276%.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants