Bump FAB to 2.0.0 #7323

dpgaspar · 2019-04-18T13:20:12Z

ADDITIONAL INFORMATION

Introduces new feature or API

CHANGELOG from FAB since version 1.12.5:

Improvements and Bug fixes on 2.0.0

Fix, vera_liu-deleted dashboard title column in welcome page #951 M-M fields are always required, now they default to not required with optional required flag on col info dict
Fix, Add per database permissions for the SQL Lab. #885 list view ordering problem of related model with dotted notation, fixes "Table [table_name] doesn't seem to exist, couldn't fetch metadata" #884
Fix, Async support for the queries in the SQL Lab. WIP. #946 Factory app pattern
(DEPRECATION) New, command line integrated with Flask cli, fabmanager is deprecated and will be removed on 2.2.X
New, config key, FAB_SECURITY_MANAGER_CLASS to declare custom SecurityManager classes.
New, sub command 'create-permissions' to create all permissions when update_perms is False.
New, config key, FAB_UPDATE_PERMS to flag FAB to update or not update permissions.
Fix, viz: cache datetime.now() in query_obj #955 Find permission view menu superset issue Permission creating hook on table creation is broken. #1944
Fix, new version location, removed deprecated imp package from setup

Improvements and Bug fixes on 1.13.0

New, CRUD RESTful API and custom API

codecov-io · 2019-04-18T15:37:53Z

Codecov Report

Merging #7323 into master will decrease coverage by <.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #7323      +/-   ##
==========================================
- Coverage   64.89%   64.89%   -0.01%     
==========================================
  Files         428      428              
  Lines       20934    20935       +1     
  Branches     2330     2330              
==========================================
  Hits        13585    13585              
- Misses       7225     7226       +1     
  Partials      124      124

Impacted Files	Coverage Δ
superset/utils/core.py	`88.16% <ø> (-0.07%)`	⬇️
superset/cli.py	`34.92% <0%> (-0.14%)`	⬇️
superset/__init__.py	`74.04% <100%> (ø)`	⬆️
superset/security.py	`76.19% <0%> (+0.31%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f28027...e0c0d3e. Read the comment docs.

mistercrunch · 2019-04-18T16:28:01Z

For all breaking changes, we should document them here:
https://github.com/apache/incubator-superset/blob/master/UPDATING.md

I think the target version will be 0.33.0 but we can always alter that later as it becomes more clear which version this will be part of.

We probably want to remove the logic around the SUPERSET_UPDATE_PERMS env var if possible, and fix the docs here:
https://github.com/apache/incubator-superset/blob/master/docs/installation.rst#flask-appbuilder-permissions

dpgaspar · 2019-04-18T18:59:01Z

ok, will do

Registering sources needs to be performed after the views are initialized on UPDATE_PERMS=False configuration

mistercrunch · 2019-04-20T20:09:00Z

superset/__init__.py

@@ -202,7 +201,6 @@ def index(self):
    base_template='superset/base.html',
    indexview=MyIndexView,
    security_manager_class=custom_sm,
-    update_perms=get_update_perms_flag(),


I think we should make this False now, and assume people will have to run superset init once per deploy

I think now we need to call appbuilder.add_permissions(update_perms=True) from superset.cli.init

FAB defaults to True on update_perms, so that we get the same behavior.
My reasoning is that the present change will create all permissions on start just like before.
If we want to disable the permission creation (avoid contention on the db on startup),
FAB_UPDATE_PERMS=False and run superset init once per deploy.

I would say that appbuilder.add_permissions(update_perms=True) can be achieved by calling the new flask fab create-permissions. I noticed that superset db upgrade creates and upgrades the db, leaving it already with bootstrap permissions and superset init created Superset's extra roles even with FAB_UPDATE_PERMS=False (so all is good).

Ok, let's add another note in UPDATE.md about FAB_UPDATE_PERMS = False being the new equivalent to the envvar SUPERSET_UPDATE_PERMS=0.

I think it'd be good to call appbuilder.add_permissions(update_perms=True) within superset init, so that we people don't have to also flask fab create-permissions at every deploy. I don't think using create-permissions is documented anywhere on our side. I think it's easier to make superset init do more instead of documenting using flask fab

Makes sense, new commit.

mistercrunch · 2019-04-23T15:29:21Z

2 lint errors https://travis-ci.org/apache/incubator-superset/jobs/523387518

dpgaspar · 2019-04-24T19:46:44Z

After merge with master fails with:

  1) Dashboard save "before each" hook for "should save/overwrite dashboard":
     Error: Blocked a frame with origin "http://localhost:8081" from accessing a cross-origin frame.

?

* filter out all nan series (#7313) * improve not rich tooltip (#7345) * Create issue_label_bot.yaml (#7341) * fix: do not save colors without a color scheme (#7347) * [wtforms] Strip leading/trailing whitespace (#7084) * [schema] Updating the datasources schema (#5451) * limit tables/views returned if schema is not provided (#7358) * limit tables/views returned if schema is not provided * fix typo * improve code performance * handle the case when table name or view name does not present a schema * Add type anno (#7342) * Updated local dev instructions to include missing step * First pass at type annotations * [schema] Updating the base column schema (#5452) * Update 937d04c16b64_update_datasources.py (#7361) * Feature flag for client cache (#7348) * Feature flag for client cache * Fix integration test * Revert "Fix integration test" This reverts commit 58434ab. * Feature flag for client cache * Fix integration tests * Add feature flag to config.py * Add another feature check * Fix more integration tests * Fix raw HTML in SliceAdder (#7338) * remove backendSync.json (#7331) * [bubbles] issue when using duplicated metrics (#7087) * SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 (#7359) * SUPERSET-8: Update text in docs copyright footer (#7360) * SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 * SUPERSET-8: Extra text in docs copyright footer * [schema] Adding commits and removing unnecessary foreign-key definitions (#7371) * Store last selected dashboard in sessionStorage (#7181) * Store last selected dashboard in sessionStorage * Fix tests * [schema] Updating the base metric schema (#5453) * Fix NoneType bug & fill the test recipients with original recipients if empty (#7365) * Added living goods as among the users of Superset (#7407) * Added living goods as among the users of Superset Living Goods is a non profit organisation with operation in africa and the middle east. We work in community health use data heavily on day to day. Superset is our platform of choice for dashboards. * Update README.md * [dashboard] allow user re-order top-level tabs (#7390) * [SQL Lab] Increase timeout threshold for offline check (#7411) * Bump FAB to 2.0.0 (#7323) * Bump FAB to 2.0.0 * [tests] whitelist SecurityApi login and refresh endpoints * [style] Fix, C812 missing trailing commas * [security] Remove SUPERSET_UPDATE_PERMS flag Registering sources needs to be performed after the views are initialized on UPDATE_PERMS=False configuration * [docs] New, FAB_UPDATE_PERMS and flask fab cli * [docs] Fix, db upgrade needs to come first, create-admin needs a db * [cli] New, superset init bootstraps all permissions for FAB and Superset * [style] Fix, flakes * [annotations] Improves UX on annotation validation, start_dttm, end_dttm (#7326) * Setting renderTrigger on label_colors (#7410) * Refactor out controlUtils.js module + unit tests (#7350) * [WiP]refactor out a controlUtils.js file * unit tests * add missing license * Addressing comments * feature: see Presto row and array data types (#7413) * Merge lastest from master into lyft-release-sp8 (#7405) * filter out all nan series (#7313) * improve not rich tooltip (#7345) * Create issue_label_bot.yaml (#7341) * fix: do not save colors without a color scheme (#7347) * [wtforms] Strip leading/trailing whitespace (#7084) * [schema] Updating the datasources schema (#5451) * limit tables/views returned if schema is not provided (#7358) * limit tables/views returned if schema is not provided * fix typo * improve code performance * handle the case when table name or view name does not present a schema * Add type anno (#7342) * Updated local dev instructions to include missing step * First pass at type annotations * [schema] Updating the base column schema (#5452) * Update 937d04c16b64_update_datasources.py (#7361) * Feature flag for client cache (#7348) * Feature flag for client cache * Fix integration test * Revert "Fix integration test" This reverts commit 58434ab. * Feature flag for client cache * Fix integration tests * Add feature flag to config.py * Add another feature check * Fix more integration tests * Fix raw HTML in SliceAdder (#7338) * remove backendSync.json (#7331) * [bubbles] issue when using duplicated metrics (#7087) * SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 (#7359) * SUPERSET-8: Update text in docs copyright footer (#7360) * SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 * SUPERSET-8: Extra text in docs copyright footer * [schema] Adding commits and removing unnecessary foreign-key definitions (#7371) * Store last selected dashboard in sessionStorage (#7181) * Store last selected dashboard in sessionStorage * Fix tests * [schema] Updating the base metric schema (#5453) * Fix NoneType bug & fill the test recipients with original recipients if empty (#7365) * feat: see Presto row and array data types (#7391) * feat: see Presto row and array data types * fix: address PR comments * fix: lint and build issues * fix: add types * add stronger type hints where possible * fix: lint issues and add select_star func in Hive * add missing pkg init * fix: build issues * fix: pylint issues * fix: use logging instead of print * Removed --console-log and superset runserver (#7421) * Fixes dashboard export button missing download and #7353 (#7427) * Added additional German translations to string file (#6604) * Added additional German translations to string file Updates to German translation files as per directions * Removed messages.json * [fix] Fixing SQL parsing issue (#7374) * add chinese translate (#7402) * Quick fix to address deadlock issue (#7434) * feat: view presto row objects in data grid (#7445) * Merge lastest from master into lyft-release-sp8 (#7405) * filter out all nan series (#7313) * improve not rich tooltip (#7345) * Create issue_label_bot.yaml (#7341) * fix: do not save colors without a color scheme (#7347) * [wtforms] Strip leading/trailing whitespace (#7084) * [schema] Updating the datasources schema (#5451) * limit tables/views returned if schema is not provided (#7358) * limit tables/views returned if schema is not provided * fix typo * improve code performance * handle the case when table name or view name does not present a schema * Add type anno (#7342) * Updated local dev instructions to include missing step * First pass at type annotations * [schema] Updating the base column schema (#5452) * Update 937d04c16b64_update_datasources.py (#7361) * Feature flag for client cache (#7348) * Feature flag for client cache * Fix integration test * Revert "Fix integration test" This reverts commit 58434ab. * Feature flag for client cache * Fix integration tests * Add feature flag to config.py * Add another feature check * Fix more integration tests * Fix raw HTML in SliceAdder (#7338) * remove backendSync.json (#7331) * [bubbles] issue when using duplicated metrics (#7087) * SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 (#7359) * SUPERSET-8: Update text in docs copyright footer (#7360) * SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 * SUPERSET-8: Extra text in docs copyright footer * [schema] Adding commits and removing unnecessary foreign-key definitions (#7371) * Store last selected dashboard in sessionStorage (#7181) * Store last selected dashboard in sessionStorage * Fix tests * [schema] Updating the base metric schema (#5453) * Fix NoneType bug & fill the test recipients with original recipients if empty (#7365) * feat: see Presto row and array data types (#7391) * feat: see Presto row and array data types * fix: address PR comments * fix: lint and build issues * fix: add types * Incorporate feedback from initial PR (prematurely merged to lyft-release-sp8) (#7415) * add stronger type hints where possible * fix: lint issues and add select_star func in Hive * add missing pkg init * fix: build issues * fix: pylint issues * fix: use logging instead of print * feat: view presto row objects in data grid * fix: address feedback * fix: spacing * feat: Scheduling queries from SQL Lab (#7416) (#7446) * Merge lastest from master into lyft-release-sp8 (#7405) * filter out all nan series (#7313) * improve not rich tooltip (#7345) * Create issue_label_bot.yaml (#7341) * fix: do not save colors without a color scheme (#7347) * [wtforms] Strip leading/trailing whitespace (#7084) * [schema] Updating the datasources schema (#5451) * limit tables/views returned if schema is not provided (#7358) * limit tables/views returned if schema is not provided * fix typo * improve code performance * handle the case when table name or view name does not present a schema * Add type anno (#7342) * Updated local dev instructions to include missing step * First pass at type annotations * [schema] Updating the base column schema (#5452) * Update 937d04c16b64_update_datasources.py (#7361) * Feature flag for client cache (#7348) * Feature flag for client cache * Fix integration test * Revert "Fix integration test" This reverts commit 58434ab. * Feature flag for client cache * Fix integration tests * Add feature flag to config.py * Add another feature check * Fix more integration tests * Fix raw HTML in SliceAdder (#7338) * remove backendSync.json (#7331) * [bubbles] issue when using duplicated metrics (#7087) * SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 (#7359) * SUPERSET-8: Update text in docs copyright footer (#7360) * SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 * SUPERSET-8: Extra text in docs copyright footer * [schema] Adding commits and removing unnecessary foreign-key definitions (#7371) * Store last selected dashboard in sessionStorage (#7181) * Store last selected dashboard in sessionStorage * Fix tests * [schema] Updating the base metric schema (#5453) * Fix NoneType bug & fill the test recipients with original recipients if empty (#7365) * feat: see Presto row and array data types (#7391) * feat: see Presto row and array data types * fix: address PR comments * fix: lint and build issues * fix: add types * Incorporate feedback from initial PR (prematurely merged to lyft-release-sp8) (#7415) * add stronger type hints where possible * fix: lint issues and add select_star func in Hive * add missing pkg init * fix: build issues * fix: pylint issues * fix: use logging instead of print * feat: view presto row objects in data grid * fix: address feedback * fix: spacing * Workaround for no results returned (#7442) * feat: view presto row objects in data grid (#7436) * feat: view presto row objects in data grid * fix: address feedback * fix: spacing * feat: Scheduling queries from SQL Lab (#7416) * Lightweight pipelines POC * Add docs * Minor fixes * Remove Lyft URL * Use enum * Minor fix * Fix unit tests * Mark props as required * feat: Add `validate_sql_json` endpoint for checking that a given sql query is valid for the chosen database (#7422) (#7462) merge from lyft-release-sp8 to master * Adds missing metric sum__SP_RUR_TOTL (#7452) * Late import for optional lib pyhive (#7471) * Late import for optional lib pyhive * fix * fix: calendar heatmap examples (#7375) Fixing a set of examples that trip on ValueError vs TypeError * bugfix: Improve support for special characters in schema and table names (#7297) * Bugfix to SQL Lab to support tables and schemas with characters that require quoting * Remove debugging prints * Add uri encoding to secondary tables call * Quote schema names for presto * Quote selected_schema on Snowflake, MySQL and Hive * Remove redundant parens * Add python unit tests * Add js unit test * Fix flake8 linting error * [dashboard] After update filter, trigger new queries when charts are visible (#7233) * trigger query when chart is visible * add integration test * fix: alter sql columns to long text #7463 (#7476) Merge lyft-release-sp8@7bfe7bc to master * Refactor ConsoleLog (#7428) * Revised Chinese translation (#7464) * add chinese translate * edit chinese translation * druid connector: avoid using 'dimensions' for scan queries (#7377) After the following PyDruid change (contained in version 0.5.2) the Superset Histogram charts rendered with Druid data are broken: druid-io/pydruid@0a59a70 Bump the pydruid requirements accordingly in setup.py Issue: #7368

* Bump FAB to 2.0.0 * [tests] whitelist SecurityApi login and refresh endpoints * [style] Fix, C812 missing trailing commas * [security] Remove SUPERSET_UPDATE_PERMS flag Registering sources needs to be performed after the views are initialized on UPDATE_PERMS=False configuration * [docs] New, FAB_UPDATE_PERMS and flask fab cli * [docs] Fix, db upgrade needs to come first, create-admin needs a db * [cli] New, superset init bootstraps all permissions for FAB and Superset * [style] Fix, flakes (cherry picked from commit 06c4610)

Upon start, by default, FAB tries to go and update the permission list in the database based on the list of views, models and menu items that exist in the code. Really this should happen once per deployment/upgrade and not in module scope, so we have `superset init` for this. The intent was always to set to False by default, but I think we forgot to add this flag back in apache#7323

* [FAB] set AppBuilder to update_perms=False Upon start, by default, FAB tries to go and update the permission list in the database based on the list of views, models and menu items that exist in the code. Really this should happen once per deployment/upgrade and not in module scope, so we have `superset init` for this. The intent was always to set to False by default, but I think we forgot to add this flag back in #7323 * Add superset init to tox

* [FAB] set AppBuilder to update_perms=False Upon start, by default, FAB tries to go and update the permission list in the database based on the list of views, models and menu items that exist in the code. Really this should happen once per deployment/upgrade and not in module scope, so we have `superset init` for this. The intent was always to set to False by default, but I think we forgot to add this flag back in #7323 * Add superset init to tox (cherry picked from commit eb42936)

* [FAB] set AppBuilder to update_perms=False Upon start, by default, FAB tries to go and update the permission list in the database based on the list of views, models and menu items that exist in the code. Really this should happen once per deployment/upgrade and not in module scope, so we have `superset init` for this. The intent was always to set to False by default, but I think we forgot to add this flag back in apache/superset#7323 * Add superset init to tox (cherry picked from commit eb4293654e8557a208a7a08b71ab22163c428362)

* Bump FAB to 2.0.0 * [tests] whitelist SecurityApi login and refresh endpoints * [style] Fix, C812 missing trailing commas * [security] Remove SUPERSET_UPDATE_PERMS flag Registering sources needs to be performed after the views are initialized on UPDATE_PERMS=False configuration * [docs] New, FAB_UPDATE_PERMS and flask fab cli * [docs] Fix, db upgrade needs to come first, create-admin needs a db * [cli] New, superset init bootstraps all permissions for FAB and Superset * [style] Fix, flakes (cherry picked from commit 556ce99)

* [FAB] set AppBuilder to update_perms=False Upon start, by default, FAB tries to go and update the permission list in the database based on the list of views, models and menu items that exist in the code. Really this should happen once per deployment/upgrade and not in module scope, so we have `superset init` for this. The intent was always to set to False by default, but I think we forgot to add this flag back in apache#7323 * Add superset init to tox (cherry picked from commit bfd7818)

dpgaspar added 3 commits April 18, 2019 14:08

Bump FAB to 2.0.0

bb96a8d

[tests] whitelist SecurityApi login and refresh endpoints

c9c2dd0

[style] Fix, C812 missing trailing commas

21fa309

dpgaspar added 4 commits April 19, 2019 12:57

[security] Remove SUPERSET_UPDATE_PERMS flag

e2eec2f

Registering sources needs to be performed after the views are initialized on UPDATE_PERMS=False configuration

[docs] New, FAB_UPDATE_PERMS and flask fab cli

19aa5e2

Merge branch 'master' into fab_2.0.0

b39a0d6

[docs] Fix, db upgrade needs to come first, create-admin needs a db

87523c4

mistercrunch reviewed Apr 20, 2019

View reviewed changes

[cli] New, superset init bootstraps all permissions for FAB and Superset

6b34e12

dpgaspar mentioned this pull request Apr 23, 2019

[security] New, deprecate merge_perm, FAB method is fixed #7355

Merged

2 tasks

[style] Fix, flakes

e0c0d3e

mistercrunch approved these changes Apr 23, 2019

View reviewed changes

Merge branch 'master' into fab_2.0.0

5885884

Merge branch 'master' into fab_2.0.0

4b37cac

mistercrunch approved these changes Apr 29, 2019

View reviewed changes

mistercrunch merged commit 06c4610 into apache:master Apr 30, 2019

mistercrunch mentioned this pull request May 21, 2019

[FAB] set AppBuilder to update_perms=False #7561

Merged

1 task

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump FAB to 2.0.0 #7323

Bump FAB to 2.0.0 #7323

dpgaspar commented Apr 18, 2019 •

edited

Loading

codecov-io commented Apr 18, 2019 •

edited

Loading

mistercrunch commented Apr 18, 2019

dpgaspar commented Apr 18, 2019

mistercrunch Apr 20, 2019

mistercrunch Apr 20, 2019

dpgaspar Apr 22, 2019

mistercrunch Apr 22, 2019

dpgaspar Apr 23, 2019

mistercrunch commented Apr 23, 2019

dpgaspar commented Apr 24, 2019

Bump FAB to 2.0.0 #7323

Bump FAB to 2.0.0 #7323

Conversation

dpgaspar commented Apr 18, 2019 • edited Loading

CATEGORY

ADDITIONAL INFORMATION

Improvements and Bug fixes on 2.0.0

Improvements and Bug fixes on 1.13.0

codecov-io commented Apr 18, 2019 • edited Loading

Codecov Report

mistercrunch commented Apr 18, 2019

dpgaspar commented Apr 18, 2019

mistercrunch Apr 20, 2019

Choose a reason for hiding this comment

mistercrunch Apr 20, 2019

Choose a reason for hiding this comment

dpgaspar Apr 22, 2019

Choose a reason for hiding this comment

mistercrunch Apr 22, 2019

Choose a reason for hiding this comment

dpgaspar Apr 23, 2019

Choose a reason for hiding this comment

mistercrunch commented Apr 23, 2019

dpgaspar commented Apr 24, 2019

dpgaspar commented Apr 18, 2019 •

edited

Loading

codecov-io commented Apr 18, 2019 •

edited

Loading