Improve time shift #5140
Merged
Improve time shift #5140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5140 +/- ##
==========================================
- Coverage 77.48% 77.47% -0.02%
==========================================
Files 44 44
Lines 8737 8741 +4
==========================================
+ Hits 6770 6772 +2
- Misses 1967 1969 +2
Continue to review full report at Codecov.
|
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
* Improve time shift color and pattern * Revert change * Fix js unit test * Move code to better place, add unit test * Move classed code to backend * Remove console.log * Remove 1 hour time compare * Remove unused import
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Aug 14, 2018
* Improve time shift color and pattern * Revert change * Fix js unit test * Move code to better place, add unit test * Move classed code to backend * Remove console.log * Remove 1 hour time compare * Remove unused import (cherry picked from commit 57e1256)
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Aug 15, 2018
graceguo-supercat
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Aug 15, 2018
Rollback cherrypick apache#5140
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Improve time shift color and pattern * Revert change * Fix js unit test * Move code to better place, add unit test * Move classed code to backend * Remove console.log * Remove 1 hour time compare * Remove unused import
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5067 introduced the ability to add multiple time shifts. Unfortunately, it broke the color matching between a time series and its time shift, since before the time shift was identified by
---, and now we actually label them1 hour offset,2 days offset, etc.This PR fixes that bug, adding a constant in
utils/common.jsto identify time shifts (so future updates only need to be done in one place). It also improves the multiple time shifts by adding different line patterns for each time shift, eg, dotted, dashed, dot-dashed. I added 10 new styles for the lines, which will be rotated for all the time shifts. The pattern is consistent across time shifts, ie, all1 hour offsetseries will have the same pattern.