Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining slice references #4899

Merged
merged 1 commit into from
May 4, 2018
Merged

Remove remaining slice references #4899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset/assets/src/addSlice/AddSliceContainer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export default class AddSliceContainer extends React.PureComponent {
render() {
return (
<div className="container">
<Panel header={<h3>{t('Create a new slice')}</h3>}>
<Panel header={<h3>{t('Create a new chart')}</h3>}>
<div>
<p>{t('Choose a datasource')}</p>
<div style={styleSelectWidth}>
Expand Down
2 changes: 1 addition & 1 deletion superset/assets/src/components/AlteredSliceTag.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export default class AlteredSliceTag extends React.Component {
<ModalTrigger
animation
triggerNode={this.renderTriggerNode()}
modalTitle={t('Slice changes')}
modalTitle={t('Chart changes')}
bsSize="large"
modalBody={this.renderModalBody()}
/>
Expand Down
2 changes: 1 addition & 1 deletion superset/assets/src/dashboard/components/SaveModal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class SaveModal extends React.PureComponent {
checked={this.state.duplicateSlices}
onChange={this.toggleDuplicateSlices.bind(this)}
/>
<span className="m-l-5">also copy (duplicate) slices</span>
<span className="m-l-5">also copy (duplicate) charts</span>
</div>
</FormGroup>
}
Expand Down
10 changes: 5 additions & 5 deletions superset/assets/src/dashboard/components/SliceAdder.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class SliceAdder extends React.Component {
error: (error) => {
this.errored = true;
this.setState({
errorMsg: t('Sorry, there was an error fetching slices to this dashboard: ') +
errorMsg: t('Sorry, there was an error fetching charts to this dashboard: ') +
this.getAjaxErrorMsg(error),
});
},
Expand All @@ -90,7 +90,7 @@ class SliceAdder extends React.Component {
.fail((error) => {
adder.errored = true;
adder.setState({
errorMsg: t('Sorry, there was an error adding slices to this dashboard: ') +
errorMsg: t('Sorry, there was an error adding charts to this dashboard: ') +
this.getAjaxErrorMsg(error),
});
});
Expand Down Expand Up @@ -193,7 +193,7 @@ class SliceAdder extends React.Component {
onClick={this.addSlices}
disabled={!enableAddSlice}
>
{t('Add Slices')}
{t('Add Charts')}
</button>
</div>
</div>
Expand All @@ -202,13 +202,13 @@ class SliceAdder extends React.Component {
return (
<ModalTrigger
triggerNode={this.props.triggerNode}
tooltip={t('Add a new slice to the dashboard')}
tooltip={t('Add a new chart to the dashboard')}
beforeOpen={this.onEnterModal.bind(this)}
isMenuItem
modalBody={modalContent}
bsSize="large"
setModalAsTriggerChildren
modalTitle={t('Add Slices to Dashboard')}
modalTitle={t('Add Charts to Dashboard')}
/>
);
}
Expand Down