Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explore] including auto generated avg metrics in druid #4718

Conversation

gabe-lyons
Copy link
Contributor

@gabe-lyons gabe-lyons commented Mar 29, 2018

AVG is a more in-depth post aggregation in druid, and I didn't include that in the v0 of adhoc metrics (#4663). However, that PR did exclude auto-generated avg metrics in druid, meaning there's no way to access and avg-based metric in explore currently. This PR whitelists auto generated avg metrics specifically for druid so those calculations can still be accessed.

test plan:

  • view a sqla datasource with auto generated avg metrics. verify they do not appear
  • view a druid datasource with autogenerated avg metrics. verify they do appear
  • run tests

reviewers:
@michellethomas @mistercrunch @williaster @graceguo-supercat

@codecov-io
Copy link

codecov-io commented Mar 29, 2018

Codecov Report

Merging #4718 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4718      +/-   ##
==========================================
+ Coverage   71.87%   71.88%   +<.01%     
==========================================
  Files         204      204              
  Lines       15323    15326       +3     
  Branches     1177     1176       -1     
==========================================
+ Hits        11014    11017       +3     
  Misses       4306     4306              
  Partials        3        3
Impacted Files Coverage Δ
...pts/explore/components/controls/MetricsControl.jsx 78.91% <100%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f952ec2...431b219. Read the comment docs.

@michellethomas
Copy link
Contributor

lgtm

@graceguo-supercat graceguo-supercat merged commit 1ef856e into apache:master Apr 2, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants