Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cosmetic] removing table border in ModelView list #4638

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Mar 18, 2018

Minimal changes using FAB inheritance to remove the table borders on CRUD list views.

Before

screen shot 2018-03-17 at 8 39 30 pm

After

screen shot 2018-03-17 at 8 39 14 pm

@codecov-io
Copy link

codecov-io commented Mar 18, 2018

Codecov Report

Merging #4638 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4638      +/-   ##
==========================================
+ Coverage   71.22%   71.22%   +<.01%     
==========================================
  Files         190      190              
  Lines       14880    14883       +3     
  Branches     1098     1098              
==========================================
+ Hits        10598    10601       +3     
  Misses       4279     4279              
  Partials        3        3
Impacted Files Coverage Δ
superset/views/base.py 58.25% <100%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97afcd5...7da1c87. Read the comment docs.

@williaster
Copy link
Contributor

wohoo lgtm

@mistercrunch mistercrunch merged commit 83f8f98 into apache:master Mar 19, 2018
@mistercrunch mistercrunch deleted the cosmetic_borderless branch March 19, 2018 18:02
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants