Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explore] Save custom url parameters when user save slices #4578

Merged

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Mar 8, 2018

fix #4439

  • when user passed custom parameters in /explore/ request, i wrap these request parameters into url_params inside form_data. So that request parameters become part of query state.

  • when user save slice, i will save this form_data as slice parameter, so that query state is persistence.

  • I also update jinja helper function url_param to read url_params from post form as well as other request parameters.

Grace Guo added 4 commits March 8, 2018 12:36
@codecov-io
Copy link

Codecov Report

Merging #4578 into master will decrease coverage by 0.02%.
The diff coverage is 51.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4578      +/-   ##
==========================================
- Coverage    71.2%   71.17%   -0.03%     
==========================================
  Files         187      187              
  Lines       14785    14809      +24     
  Branches     1083     1085       +2     
==========================================
+ Hits        10527    10540      +13     
- Misses       4255     4266      +11     
  Partials        3        3
Impacted Files Coverage Δ
...cripts/explore/components/ExploreViewContainer.jsx 0% <0%> (ø) ⬆️
superset/assets/javascripts/explore/index.jsx 0% <0%> (ø) ⬆️
superset/utils.py 88.12% <100%> (+0.18%) ⬆️
superset/views/core.py 71.2% <100%> (+0.04%) ⬆️
superset/jinja_context.py 73.33% <12.5%> (-4.93%) ⬇️
...uperset/assets/javascripts/explore/stores/store.js 53.94% <75%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ebcaa...d34ca5a. Read the comment docs.

@michellethomas
Copy link
Contributor

lgtm

@graceguo-supercat graceguo-supercat merged commit 9edbd64 into apache:master Mar 8, 2018
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Mar 8, 2018
* [Explore] Save url parameters when user save slices

* remove print

(cherry picked from commit bd9ecbe)

* add unit test

(cherry picked from commit 0f350ad)

* wrapping all request params into url_params

(cherry picked from commit 17197c1)

(cherry picked from commit 9edbd64)
graceguo-supercat pushed a commit to airbnb/superset-fork that referenced this pull request Mar 8, 2018
Cherry Pick: [Explore] Save custom url parameters when user save slices (apache#4578)
@graceguo-supercat graceguo-supercat deleted the gg-UpdateFixUrlParams branch March 9, 2018 07:58
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
* [Explore] Save url parameters when user save slices

* remove print

(cherry picked from commit bd9ecbe)

* add unit test

(cherry picked from commit 0f350ad)

* wrapping all request params into url_params

(cherry picked from commit 17197c1)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* [Explore] Save url parameters when user save slices

* remove print

(cherry picked from commit bd9ecbe)

* add unit test

(cherry picked from commit 0f350ad)

* wrapping all request params into url_params

(cherry picked from commit 17197c1)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL parameters not saved for a slice in explorer view
4 participants