-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Explore] Save custom url parameters when user save slices #4578
Merged
graceguo-supercat
merged 4 commits into
apache:master
from
graceguo-supercat:gg-UpdateFixUrlParams
Mar 8, 2018
Merged
[Explore] Save custom url parameters when user save slices #4578
graceguo-supercat
merged 4 commits into
apache:master
from
graceguo-supercat:gg-UpdateFixUrlParams
Mar 8, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4578 +/- ##
==========================================
- Coverage 71.2% 71.17% -0.03%
==========================================
Files 187 187
Lines 14785 14809 +24
Branches 1083 1085 +2
==========================================
+ Hits 10527 10540 +13
- Misses 4255 4266 +11
Partials 3 3
Continue to review full report at Codecov.
|
lgtm |
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Mar 8, 2018
graceguo-supercat
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Mar 8, 2018
Cherry Pick: [Explore] Save custom url parameters when user save slices (apache#4578)
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 0.24.0
labels
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4439
when user passed custom parameters in /explore/ request, i wrap these request parameters into
url_params
inside form_data. So that request parameters become part of query state.when user save slice, i will save this form_data as slice parameter, so that query state is persistence.
I also update jinja helper function url_param to read
url_params
from post form as well as other request parameters.