Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[landing] Making Dashboards the first/default tab #4553

Merged
merged 1 commit into from
Mar 7, 2018
Merged

[landing] Making Dashboards the first/default tab #4553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions superset/assets/javascripts/welcome/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,25 +25,7 @@ export default class App extends React.PureComponent {
return (
<div className="container welcome">
<Tabs defaultActiveKey={1} id="uncontrolled-tab-example">
<Tab eventKey={1} title={t('Recently Viewed')}>
<Panel>
<Row>
<Col md={8}><h2>{t('Recently Viewed')}</h2></Col>
</Row>
<hr />
<RecentActivity user={this.props.user} />
</Panel>
</Tab>
<Tab eventKey={2} title={t('Favorites')}>
<Panel>
<Row>
<Col md={8}><h2>{t('Favorites')}</h2></Col>
</Row>
<hr />
<Favorites user={this.props.user} />
</Panel>
</Tab>
<Tab eventKey={3} title={t('Dashboards')}>
<Tab eventKey={1} title={t('Dashboards')}>
<Panel>
<Row>
<Col md={8}><h2>{t('Dashboards')}</h2></Col>
Expand All @@ -62,6 +44,24 @@ export default class App extends React.PureComponent {
<DashboardTable search={this.state.search} />
</Panel>
</Tab>
<Tab eventKey={2} title={t('Recently Viewed')}>
<Panel>
<Row>
<Col md={8}><h2>{t('Recently Viewed')}</h2></Col>
</Row>
<hr />
<RecentActivity user={this.props.user} />
</Panel>
</Tab>
<Tab eventKey={3} title={t('Favorites')}>
<Panel>
<Row>
<Col md={8}><h2>{t('Favorites')}</h2></Col>
</Row>
<hr />
<Favorites user={this.props.user} />
</Panel>
</Tab>
</Tabs>
</div>
);
Expand Down