[bugfix] Fixing regression from #4500 #4549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley-fix-pr-4500
branch
from
ea8ac1e
to
aef8ad3
Compare
Codecov Report
@@ Coverage Diff @@
## master #4549 +/- ##
==========================================
+ Coverage 71.12% 71.19% +0.06%
==========================================
Files 187 187
Lines 14780 14780
Branches 1083 1083
==========================================
+ Hits 10513 10523 +10
+ Misses 4264 4254 -10
Partials 3 3
Continue to review full report at Codecov.
|
|
Niiiiice. |
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Mar 7, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 14, 2018
(cherry picked from commit ef4e5ec)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 1, 2018
* Cherry pick apache#4581 * Add flask-compress cherry * Add shortner fix * Add Return __time in Druid scan apache#4504 * Picking cherry Fixing regression from apache#4500 (apache#4549) * [bugfix] SQL Lab 'MySQL has gone away' It appears the 'MySQL has gone away' is triggered by the line of code I wrapped in a try block here. This is a temporary fix, there will be another PR shortly getting to the bottom of this. Related: https://github.com/lyft/druidstream/issues/40
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression with markup visualizations which was introduced in #4500.
to: @mistercrunch