utf8 fixes to csv -> hive upload #4488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timifasubaa
changed the title
timifasubaa
changed the title
|
I think simply using the |
timifasubaa
force-pushed
the
upload_csv_fixes
branch
2 times, most recently
from
c02fbd7
to
5f991db
Compare
|
@john-bodley Done. Good call. |
timifasubaa
force-pushed
the
upload_csv_fixes
branch
3 times, most recently
from
8dc9d42
to
42f4ffa
Compare
john-bodley
reviewed
Feb 27, 2018
superset/db_engine_specs.py
Outdated
| @@ -868,16 +868,17 @@ def get_column_names(filepath): | |||
| secure_filename(form.csv_file.data.filename) | |||
| column_names = get_column_names(upload_path) | |||
| schema_definition = ', '.join( | |||
| [s + ' STRING ' for s in column_names]) | |||
| [s.decode('utf-8') + ' STRING ' for s in column_names]) | |||
There was a problem hiding this comment.
Why do we need to use decode here?
There was a problem hiding this comment.
You were right. It is no longer needed after using unicodecsv. Thanks!
john-bodley
reviewed
Feb 27, 2018
|
|
||
| s3 = boto3.client('s3') | ||
| location = os.path.join('s3a://', bucket_path, upload_prefix, table_name) | ||
| s3.upload_file( | ||
| upload_path, 'airbnb-superset', | ||
| upload_path, bucket_path, |
timifasubaa
force-pushed
the
upload_csv_fixes
branch
from
42f4ffa
to
eccd942
Compare
timifasubaa
force-pushed
the
upload_csv_fixes
branch
from
eccd942
to
87f069c
Compare
|
LGTM |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
john-bodley
reviewed
Apr 26, 2019
| os.path.join(upload_prefix, table_name, filename)) | ||
| sql = """CREATE EXTERNAL TABLE {table_name} ( {schema_definition} ) | ||
| ROW FORMAT DELIMITED FIELDS TERMINATED BY ',' STORED AS | ||
| TEXTFILE LOCATION '{location}'""".format(**locals()) | ||
| TEXTFILE LOCATION '{location}' | ||
| tblproperties ('skip.header.line.count'='1')""".format(**locals()) |
There was a problem hiding this comment.
Note the skip.header.line.count property will only work in Presto for v0.199 or later per here.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes 4 issues.
How was this tested?
Tested on my development machine.
@john-bodley @mistercrunch