Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Remedy for Dual Axis chart render bug #4130

Merged
merged 1 commit into from
Jan 2, 2018
Merged

[Bugfix] Remedy for Dual Axis chart render bug #4130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions superset/assets/visualizations/nvd3_vis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ function nvd3Vis(slice, payload) {
} else {
xMin = chart.xAxis.scale().domain()[0].valueOf();
xMax = chart.xAxis.scale().domain()[1].valueOf();
xScale = chart.xScale();
xScale = chart.xScale ? chart.xScale() : d3.scale.linear();
}

if (Array.isArray(formulas) && formulas.length) {
Expand Down Expand Up @@ -591,8 +591,8 @@ function nvd3Vis(slice, payload) {
}));
data.push(...formulaData);
}

const annotationHeight = chart.yAxis.scale().range()[0];
const yAxis = chart.yAxis1 ? chart.yAxis1 : chart.yAxis;
const annotationHeight = yAxis.scale().range()[0];
const tipFactory = layer => d3tip()
.attr('class', 'd3-tip')
.direction('n')
Expand Down