Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql lab] fix position of 'save query' Popover #3999

Merged

Commits on Dec 4, 2017

  1. [sql lab] fix position of 'save query' Popover

    The "Save Query" popover renders on the upper left corner as opposed to
    where it should (relative to the Save Query button). After a bit of
    research, it seems like Popover won't render in the right place when
    parents are absolute.
    
    I'm guessing this stopped working properly when I added the resizable
    panes.
    
    Anyhow, the solution here is to use a modal instead.
    mistercrunch committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    fecfa03 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2017

  1. Fixing tests

    mistercrunch committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    b11e5d8 View commit details
    Browse the repository at this point in the history