add annotation option and a linear color map for heatmap viz. #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
requested changes
Oct 10, 2017
| @@ -1086,6 +1087,14 @@ export const controls = { | |||
| description: t('Whether to display the legend (toggles)'), | |||
| }, | |||
|
|
|||
| show_annotation: { | |||
There was a problem hiding this comment.
The term annotation is already used for other purposes, can we just call this show_values?
| @@ -1086,6 +1087,14 @@ export const controls = { | |||
| description: t('Whether to display the legend (toggles)'), | |||
| }, | |||
|
|
|||
| show_annotation: { | |||
| type: 'CheckboxControl', | |||
| label: t('Annotation'), | |||
| label: t('Annotation'), | ||
| renderTrigger: true, | ||
| default: false, | ||
| description: t('Whether to display the annotation (toggles)'), |
There was a problem hiding this comment.
'Whether to display the numerical values within the cells'
|
|
||
| cells.append('text') | ||
| .attr('transform', | ||
| function (d) { return 'translate(' + xRbScale(d.x) + ',' + yRbScale(d.y) + ')'; }) |
There was a problem hiding this comment.
.attr('transform', d => `translate(${xRbScale(d.x}, ${yRbScale(d.y)})`
There was a problem hiding this comment.
thx! using => indeed makes it neater.
| .attr('x', xRbScale.rangeBand() / 2) | ||
| .attr('text-anchor', 'middle') | ||
| .attr('dy', '.35em') | ||
| .text(function (d) { return valueFormatter(d.v); }) |
There was a problem hiding this comment.
.text(d => valueFormatter(d.v))
| .attr('dy', '.35em') | ||
| .text(function (d) { return valueFormatter(d.v); }) | ||
| .attr('font-size', Math.min(yRbScale.rangeBand(), xRbScale.rangeBand()) / 3 + 'px') | ||
| .attr('fill', function (d) { return d.v >= payload.data.extents[1] / 2 ? 'white' : 'black'; }); |
3 similar comments
mistercrunch
approved these changes
Oct 10, 2017
eddy-geek
added a commit
to eddy-geek/incubator-superset
that referenced
this pull request
Oct 15, 2017
…t_box * remotes/origin/master: (340 commits) [New Viz] Partition Diagram (apache#3642) Add description for running specific test (apache#3665) Making the sort order for metrics pull from fd for time table viz (apache#3661) Make columns that return an exception on click unsortable. (apache#3417) Adding sort time table (apache#3651) added aihello as superset user. (apache#3647) Fix apache#3612 - reverse sign in difference calculation (apache#3646) Fixing some warnings during tests (apache#3648) [Translations] Restored lost French translations (apache#3645) [sql lab] fix impersonation + template issue (apache#3644) Pin moment.js library since 2.19.0 creates problem (apache#3641) [time_table] adding support for URLs / links (apache#3600) Set tooltip to show extent of sparkData (apache#3626) add explicit message display for 'Fetching Annotation Layer' error (apache#3631) [bugfix] Template rendering failed: '_AppCtxGlobals' object has no attribute 'user' (apache#3637) fix long title text wrapping in editable-title component (apache#3638) [minor] proper tooltip on ControlHeader's instant re-render trigger (apache#3625) add annotation option and a linear color map for heatmap viz. (apache#3634) [bugfix] empty From date filter NoneType error (apache#3633) remove unused imports (apache#3621) ...
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
…#3634) * add annotation option and a linear color map for heatmap viz. * error fixes. * fixes for requested changes
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow user to put digits on a grid heat map, which is related to #3570 and visualization for churn rate.