Feature: Display the verbose name for metrics within Timeseries charts and legend. #3504
Conversation
|
Coverage increased (+0.03%) to 69.501% when pulling 5bfe926cd918e8b9dde0b79aa49a54a6cc8f405b on tc-dc:fmenges/verbose_names_timeseries into ae7f163 on apache:master. |
fabianmenges
force-pushed
the
fmenges/verbose_names_timeseries
branch
from
5bfe926
to
cd50d2d
Compare
|
Coverage increased (+0.03%) to 69.496% when pulling cd50d2d5428e671653e2a07d1b7bec98540fb19e on tc-dc:fmenges/verbose_names_timeseries into 1cf634a on apache:master. |
fabianmenges
force-pushed
the
fmenges/verbose_names_timeseries
branch
from
cd50d2d
to
4c72864
Compare
2 similar comments
| series_title = name | ||
| else: | ||
| name = ["{}".format(s) for s in name] | ||
| if len(self.form_data.get('metrics')) > 1: |
There was a problem hiding this comment.
Users reported an issue related to removing this logic. In the case where there's a single metric and a one or many dimension, the metric name would not be reported prior to this change, which is the desired behavior. Where before using metric count with gender dimension would give ['female', 'male', 'other'] in both the legend and tooltip, now it says ['count, female', 'count, male', 'count, other']
There was a problem hiding this comment.
Please don't report this to me if you don't want me to fix it. Just wasted 30min on context switching and pushing a branch only to find your fix...
|
Should be easy to fix, I'll try to push something later today... |
mistercrunch
added
🏷️ bot
This solves the verbose name issues, like #3437, but only for nvd3Vis charts (line charts, bar charts, area charts, etc...)
The entire renaming logic was moved into JS and the presentation layer. This should address the issues that @mistercrunch brought up. I'm happy to close the other MR if we decide to go with this approach.
No need for new screenshots, they look the same.