Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react-alert for backend message flashing #3315

Merged
merged 1 commit into from
Aug 17, 2017

Conversation

mistercrunch
Copy link
Member

This also makes it easy to pass conf parameters from the backend to the frontend

@coveralls
Copy link

coveralls commented Aug 17, 2017

Coverage Status

Coverage increased (+0.09%) to 69.397% when pulling 389f9cc on mistercrunch:flashes into b9a2fa4 on apache:master.

@coveralls
Copy link

coveralls commented Aug 17, 2017

Coverage Status

Coverage increased (+0.02%) to 69.397% when pulling 389f9cc on mistercrunch:flashes into b9a2fa4 on apache:master.

@graceguo-supercat
Copy link

LGTM

@mistercrunch mistercrunch merged commit 59268e9 into apache:master Aug 17, 2017
mistercrunch added a commit to mistercrunch/superset that referenced this pull request Aug 18, 2017
mistercrunch added a commit that referenced this pull request Aug 18, 2017
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants